Remove redundant is_trimmable_whitespace in String builtin

Author: HalidOdat

core/engine/src/builtins/intl/number_format/mod.rs

@@ -1,5 +1,3 @@
-use std::borrow::Cow;
-
 use boa_gc::{Finalize, Trace};
 use fixed_decimal::{Decimal, FloatPrecision, SignDisplay};
 use icu_decimal::{
@@ -30,7 +28,7 @@ use crate::{
     NativeFunction,
     builtins::{
         BuiltInConstructor, BuiltInObject, IntrinsicObject, builder::BuiltInBuilder,
-        options::get_option, string::is_trimmable_whitespace,
+        options::get_option,
     },
     context::intrinsics::{Intrinsics, StandardConstructor, StandardConstructors},
     js_string,
@@ -825,13 +823,12 @@ fn to_intl_mathematical_value(value: &JsValue, context: &mut Context) -> JsResul
 pub(crate) fn js_string_to_fixed_decimal(string: &JsString) -> Option<Decimal> {
     // 1. Let text be ! StringToCodePoints(str).
     // 2. Let literal be ParseText(text, StringNumericLiteral).
-    let Ok(string) = string.to_std_string() else {
+    let Ok(string) = string.trim().to_std_string() else {
         // 3. If literal is a List of errors, return NaN.
         return None;
     };
     // 4. Return StringNumericValue of literal.
-    let string = string.trim_matches(is_trimmable_whitespace);
-    match string {
+    match string.as_str() {
         "" => return Some(Decimal::from(0)),
         "-Infinity" | "Infinity" | "+Infinity" => return None,
         _ => {}
@@ -856,11 +853,10 @@ pub(crate) fn js_string_to_fixed_decimal(string: &JsString) -> Option<Decimal> {
             return None;
         }
         let int = BigInt::from_str_radix(string, base).ok()?;
-        let int_str = int.to_string();
 
-        Cow::Owned(int_str)
+        int.to_string()
     } else {
-        Cow::Borrowed(string)
+        string
     };
 
     Decimal::try_from_str(&s).ok()

core/engine/src/builtins/string/mod.rs

@@ -57,26 +57,6 @@ pub(crate) enum Placement {
     End,
 }
 
-/// Helper function to check if a `char` is trimmable.
-pub(crate) const fn is_trimmable_whitespace(c: char) -> bool {
-    // The rust implementation of `trim` does not regard the same characters whitespace as ecma standard does
-    //
-    // Rust uses \p{White_Space} by default, which also includes:
-    // `\u{0085}' (next line)
-    // And does not include:
-    // '\u{FEFF}' (zero width non-breaking space)
-    // Explicit whitespace: https://tc39.es/ecma262/#sec-white-space
-    matches!(
-        c,
-        '\u{0009}' | '\u{000B}' | '\u{000C}' | '\u{0020}' | '\u{00A0}' | '\u{FEFF}' |
-    // Unicode Space_Separator category
-    '\u{1680}' | '\u{2000}'
-            ..='\u{200A}' | '\u{202F}' | '\u{205F}' | '\u{3000}' |
-    // Line terminators: https://tc39.es/ecma262/#sec-line-terminators
-    '\u{000A}' | '\u{000D}' | '\u{2028}' | '\u{2029}'
-    )
-}
-
 /// JavaScript `String` implementation.
 #[derive(Debug, Clone, Copy)]
 pub(crate) struct String;