Fix some regolith bugs #43
Merged
+38
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that Deposit Txes will be contract creations. But, the deposit tx nonce is always zero and inferred based on the order. To prevent collisions we properly utilize the computed nonce.
Previously, the deposit tx was always assumed to use all of the GasLimit in its processing. Instead, Regolith requires that the actual gas usage be reported. Gas price is always 0 so the refund logic is unaffected.
The Bedrock and Regolith computation for rollup data gas differs. This change adds the chain rules as a parameter to the computation so that it can be appropriately switched, depending on the chain state.
boyuan-chen
approved these changes
Sep 14, 2023
jyellick
pushed a commit
that referenced
this pull request
Feb 26, 2024
…asUsed Add Deposit Tx gasUsed and Fix block Fee Calculation for Otterscan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes three distinct issues (broken into three commits).
With these three fixes in place, the previously failing op-e2e p2p sync test succeeds again, and all other passing tests still pass.