Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not providing default options for payload creation #13

Open
souradeep-das opened this issue Jun 20, 2024 · 0 comments
Open

Consider not providing default options for payload creation #13

souradeep-das opened this issue Jun 20, 2024 · 0 comments

Comments

@souradeep-das
Copy link

souradeep-das commented Jun 20, 2024

const callDataReq = aaInstance.interface.encodeFunctionData('execute', [
      (transaction as any).payload.to ?? ethers.ZeroAddress,
      (transaction as any).payload.value ?? '0x00',
      (transaction as any).payload.data ?? ethers.ZeroHash,
    ]);

the callData creation currently provides defaults when the attributes do not exist on the payload provided by the front-end. Verify and check if defaults can be avoided to prevent potential user side issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant