Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PHP 8.1 and PHP 8.2 #113

Closed
bobbingwide opened this issue Sep 14, 2023 · 5 comments
Closed

Support PHP 8.1 and PHP 8.2 #113

bobbingwide opened this issue Sep 14, 2023 · 5 comments
Assignees
@bobbingwide
Labels
Blessed task

Comments

@bobbingwide
Copy link
Owner

Update code to run without problems in PHP 8.1 and 8.2

See bobbingwide/bobbingwide#103
@bobbingwide bobbingwide self-assigned this Sep 14, 2023
@bobbingwide
Copy link
Owner Author

Having made a couple of changes to oik-bwtrace so fix the deprecated messages I tried running the PHPUnit tests.
There were a couple of Deprecated messages and test failures.

@bobbingwide
Copy link
Owner Author

I resolved the PHPUnit test failures by unchecking the Enable performance trace checkbox in Settings > oik trace options.
But there were two problems

  1. In the admin interface there were two Deprecated messages.
Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in C:\apache\htdocs\wordpress\wp-includes\functions.php on line 7127

Deprecated: str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecated in C:\apache\htdocs\wordpress\wp-includes\functions.php on line 2182
  1. More importantly, there was no trace output, so no link to the trace output file.

@bobbingwide
Copy link
Owner Author

See also #106

bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Don't call trim( null ). PHP 8.2 #113
4e23db0
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Don't pass null to trailingshashit(). PHP 8.2 #113
50cc7b4
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Don't call strlen( null ). PHP 8.2 #113
6956142
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Dont trim( null). PHP 8.2 #113
196cbe9
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Don't str_replace() against a null string. PHP 8.2 #113
4c2405b
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
PHP 8.2: Change null to '' #113
01b123a
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
PHP 8.2 Declare properties #113
a0ff135
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
PHP 8.2: Don't str_replace null. Document a current restriction for E…
fdeddf1 
…nable performance trace checkbox #113
bobbingwide added a commit that referenced this issue Oct 9, 2023
@bobbingwide
Add expected EOL for PHP 8.1 and 8.2 #113
15b8ec3
@bobbingwide
Copy link
Owner Author

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in C:\apache\htdocs\wordpress\wp-content\plugins\oik-bwtrace\includes\class-trace-files-directory.php on line 275

Deprecated: Creation of dynamic property trace_files_directory::$message is deprecated in C:\apache\htdocs\wordpress\wp-content\plugins\oik-bwtrace\includes\class-trace-files-directory.php on line 119

bobbingwide added a commit that referenced this issue Dec 3, 2023
@bobbingwide
PHP 8.2 Declare properties #113
65c2938
@bobbingwide
Copy link
Owner Author

Delivered in v3.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
Blessed task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide