Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected Trace shutdown output in CSV downloads from EDD #41

Closed
bobbingwide opened this issue Aug 5, 2016 · 2 comments
Closed

Unexpected Trace shutdown output in CSV downloads from EDD #41

bobbingwide opened this issue Aug 5, 2016 · 2 comments
Assignees
Labels

Comments

@bobbingwide
Copy link
Owner

The bw_trace_ok_to_echo() function does not detect the fact that a CSV file is being downloaded in EDD. The CSV file therefore gets corrupted. We need a mechanism to prevent this from happening.
There's probably an action hook we can detect.

@bobbingwide bobbingwide self-assigned this Nov 27, 2019
@bobbingwide
Copy link
Owner Author

Hasn’t this been fixed in #78

@bobbingwide
Copy link
Owner Author

The request for an EDD Export is /wp-admin/edit.php?post_type=download&page=edd-tools&tab=import_export
with the following values:

_REQUEST Array
(
    [post_type] => download
    [page] => edd-tools
    [tab] => import_export
    [edd_action] => export_settings
    [edd_export_nonce] => 73a8dcbe83
    [_wp_http_referer] => /wp-admin/edit.php?post_type=download&page=edd-tools&tab=import_export
    [submit] => Export
)

So we can just check for edd_action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant