Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image styling in oik.css breaks background images in Google web story #152

Open
bobbingwide opened this issue Aug 20, 2020 · 1 comment
Open
Assignees
Labels
bug Needs documentation The changes should be documented before the issue can be closed

Comments

@bobbingwide
Copy link
Owner

A colleague suggested I try using Google web story plugin on a new website. When I tried to add a background image to a page the image did not cover the whole of the background in the editor. It was OK in the front end. I noticed that the display was also broken in the Stories dashboard.

Problem determination

Having failed to find where the background image was styled using the inspector we looked at the activated plugins. Deactivating oik resolved the problem. Next I reactivated oik but checked the box to not enqueue oik.css. This also resolved the problem. So then I re-enabled the enqueueing of oik.css and changed the CSS file in the inspector until the problem went away. It didn’t take lone. I simply removed

img { max-width: 100% }

Problem resolution

  • There are a couple of workarounds identified above
  • But it you want oik.css for other CSS then we have to find another solution.
  • The problem doesn’t occur in the front-end, so perhaps we don’t need to enqueue oik.css when on the Story page

OR can we simply remove the image styling?
This is where I need help. Is this the right approach? Should the web story plugin be catering for the problem?

@bobbingwide
Copy link
Owner Author

delivered in oik v4.1.0. need to write a release note. if CSS still needed use custom CSS.

@bobbingwide bobbingwide added Needs documentation The changes should be documented before the issue can be closed and removed help wanted labels Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Needs documentation The changes should be documented before the issue can be closed
Projects
None yet
Development

No branches or pull requests

1 participant