Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for phone shortcodes when Mobile phone entered but not Home phone? #223

Open
bobbingwide opened this issue Feb 1, 2024 · 0 comments
Assignees

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Feb 1, 2024

Very soon we're getting updated to Full Fibre Broadband. We'll be losing our home phone number.
It's easy enough to change our websites to blank out the home phone.
But what do we do about the shortcodes that display the home phone number?
What are the options?
Is it worth altering the shortcodes to cater for this?

Current behaviour

Each shortcode only displays the number if there's a value for it.

Shortcode Displays
bw_tel Telephone number ( inline )
bw_telephone Telehphone number ( block )
bw_mob Mobile number ( inline )
bw_mobile Mobile number ( block )
bw_emergency Emergency number
bw_fax Fax number

image

So [bw_emergency] and [bw_fax] won't display anything

Options

  1. Blank out the home phone number in Telephone
  2. Replace the number in Telephone with the Mobile number, making it the same as the Mobile
  3. Replace the number in Telephone with the Mobile number and blank out the Mobile

I'm going to try option 2.

@bobbingwide bobbingwide self-assigned this Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant