Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit tests: cater for plugins which disable wptexturize() #228

Open
bobbingwide opened this issue Jul 3, 2024 · 0 comments
Open

PHPUnit tests: cater for plugins which disable wptexturize() #228

bobbingwide opened this issue Jul 3, 2024 · 0 comments
Assignees

Comments

@bobbingwide
Copy link
Owner

I recently updated the bigram plugin to disable wptexturize logic
This function, amongst other things, converts single and double quotes to formatted entities.
Some of the PHPUnit test cases currently expect strings to contain formatted entities.
If the bigram plugin were activated then these would not be formatted by wptexturize, so the string comparison logic would fail.
One solution is to deactivate bigram before running the PHPUnit tests, another is to change the test functions to cater for the possible differences.

I tried writing code to re-enable wptexturize for the PHP Unit tests, but this is not possible with the current version of wptexturize.
There's a TRAC issue which I updated. TRAC #54721

@bobbingwide bobbingwide self-assigned this Jul 3, 2024
bobbingwide added a commit that referenced this issue Jul 4, 2024
bobbingwide added a commit that referenced this issue Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant