Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gutenberg 10.6 #23

Open
bobbingwide opened this issue May 5, 2021 · 7 comments
Open

Update for Gutenberg 10.6 #23

bobbingwide opened this issue May 5, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented May 5, 2021

It looks like I've got to implement a number of changes for Gutenberg 10.6

  1. Switch to theme.json
  2. Implement post-terms blocks for categories and tags
  3. Fix the horizontal menu styling

Switch to theme.json

In Gutenberg 10.6, the theme JSON file no longer be experimental.
It's been restructured.

We'll need a theme.json file for Gutenberg 10.6 and above with "version": 1.

And experimental-theme.json for earlier versions of Gutenberg, though this won't be maintained.

See https://github.com/WordPress/gutenberg/blob/trunk/docs/how-to-guides/themes/theme-json.md

Implement post-terms blocks for post categories and tags

There have been other changes.
post-tags and post-hierarchical-terms have become two variations of post-terms.

Fix horizontal menu styling

The menu when looking at a single-post was:
image

It's now.:

  • Lost a lot of padding
  • Everything's blue.
  • With unwanted underscoring

image

or is it? The fonts have gone tits up again. Must've been my attempt to put templateParts into theme.json without anything else!

@bobbingwide bobbingwide added the enhancement New feature or request label May 5, 2021
@bobbingwide bobbingwide self-assigned this May 5, 2021
@bobbingwide
Copy link
Owner Author

Check if the support is in v10.6.0-rc.1. If so, make the change before 12th May.

@bobbingwide
Copy link
Owner Author

bobbingwide commented May 6, 2021

I applied 10.6.0-rc.1.
In the Site Editor the local customizations were not active... the fonts weren't as expected.
But the front end was OK.

Note: I hadn't created theme.json

@bobbingwide
Copy link
Owner Author

All that was necessary it seems was to open Global Styles and change the Font family from Default to Open Sans,sans serif

@bobbingwide bobbingwide changed the title Update experimental-theme.json to theme.json for Gutenberg 10.6 Update for Gutenberg 10.6 May 7, 2021
bobbingwide added a commit that referenced this issue May 8, 2021
bobbingwide added a commit that referenced this issue May 8, 2021
bobbingwide added a commit that referenced this issue May 8, 2021
@bobbingwide
Copy link
Owner Author

bobbingwide commented May 10, 2021

Background colour in Site Editor is different from block/template editor.
Makes it difficult to check Global Styles for a striped Table, for example.

image

image

@bobbingwide
Copy link
Owner Author

bobbingwide commented May 10, 2021

When using the template editor for a post, in order to check the styling for the table block, I noted the following problems:

  1. Meta boxes fill up most of the main body. Worse than this screen capture where the meta boxes have been closed down.
  2. There's a big black border that seems necessary to support the back arrow
  3. The table block looks fine in the editor, but not at all on the front end.

So how can I style the table block using Global styles?

image

@bobbingwide
Copy link
Owner Author

  1. Meta boxes fill up most of the main body. Worse than this screen capture where the meta boxes have been closed down.

I raised an issue on Gutenberg. WordPress/gutenberg#31789

@bobbingwide
Copy link
Owner Author

  1. The table block looks fine in the editor, but not at all on the front end.

Pragmatic solution is to copy/cobble the CSS from gutenberg/build/block-library/theme.css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant