Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should navigation-links in templates / template parts use the "id" attribute? #25

Open
bobbingwide opened this issue May 6, 2021 · 0 comments
Open

Should navigation-links in templates / template parts use the "id" attribute? #25

bobbingwide opened this issue May 6, 2021 · 0 comments
Assignees
@bobbingwide
Labels
enhancement New feature or request question Further information is requested

Comments

@bobbingwide
Copy link
Owner

Should I remove the "id" attribute from navigation-link blocks delivered in the theme?

I've already got code that fiddles navigation links to change the hardcoded prefix https://s.b/wp55/thisis to site_url().
Is it true that the "id" attribute is not used in the server side rendering?
Can it be removed?
What about CSS classes?
@bobbingwide bobbingwide added the enhancement New feature or request label May 6, 2021
@bobbingwide bobbingwide self-assigned this May 6, 2021
@bobbingwide bobbingwide added the question Further information is requested label May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbingwide bobbingwide

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bobbingwide