Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace [guts] shortcode by oik-bbw/wp block with the "g" attribute #28

Open
bobbingwide opened this issue May 13, 2021 · 1 comment
Open
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

Requirement

  • Reduce the number of shortcodes used in templates and template parts

Solution

  • Replace occurrences of [guts] with the oik-bbw/wp block.

See bobbingwide/bobbingwide#22 (comment)

@bobbingwide bobbingwide added the enhancement New feature or request label May 13, 2021
@bobbingwide bobbingwide self-assigned this May 13, 2021
@bobbingwide
Copy link
Owner Author

bobbingwide commented Nov 27, 2021

oik-bob-bing-wide has been updated with a new version of the oik-bbw/wp block.
This expects the attributes to be boolean values true/false rather than a character matching the attribute name

oik-bbw/wp { "g": "g" }

causes an error action wp_error_added.

C:\apache\htdocs\wordpress\wp-content\plugins\oik-bwtrace\includes\bwtrace-actions.php(344:0) 
bw_trace_parms(1) 243 0 2021-11-27T21:42:57+00:00 0.339030 0.104035 
cf=wp_error_added 20335 36 2262 2097152/2097152 256M F=508 parameters: 4: Array
    [0] => (string) "rest_invalid_type"
    [1] => (string) "g is not of type boolean."
    [2] => Array
        [param] => (string) "g"
    [3] => WP_Error Object
        [errors] => Array
            [rest_invalid_type] => Array
                [0] => (string) "g is not of type boolean."
        [error_data] => Array
            [rest_invalid_type] => *RECURSION* 2 0
        [ * additional_data] => Array

It's not immediately obvious what the cause of the hook is, but the backtrace helped.

@bobbingwide bobbingwide added the bug Something isn't working label Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant