Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Gutenberg 10.9.0 #33

Open
bobbingwide opened this issue Jun 24, 2021 · 4 comments
Open

Update for Gutenberg 10.9.0 #33

bobbingwide opened this issue Jun 24, 2021 · 4 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Jun 24, 2021

In Gutenberg 10.9.0 the wp:query-loop block has been renamed to wp:post-template.
The Gutenberg code has been changed to cater for existing Query Loop blocks.
But ThisIs implements a Query Loop override to support order by rand.

This may or may not explain other problems that I've noted after updating to 10.9.0

  1. On front-page.html the latest-posts.html template part is showing a link to the home page, not 3 links to the most recent posts.

image

  1. The Site Logo block crashed in the Site Editor.
    image

Note: The first two messages are from oik-blocks - oik-css block is not being registered correctly - oik-blocks uses the old registration method. Time to update eh?

@bobbingwide bobbingwide added bug Something isn't working enhancement New feature or request labels Jun 24, 2021
@bobbingwide bobbingwide self-assigned this Jun 24, 2021
@bobbingwide
Copy link
Owner Author

  1. On front-page.html the latest-posts.html template part is showing a link to the home page, not 3 links to the most recent posts.

Changing the code to use wp:post-template instead of wp:query-loop resolves the problem.

Comments:

  • The Site Editor's / Block Editor's automatic changing appeared to work in the editor
  • but it didn't force the user to apply the update
  • so the front end was unchanged until I changed and saved something else.
  • The logic didn't appear to kick in for templates / template-parts using query-loop, even though the documentation suggests that query-loop should continue to work, until WordPress 5.9

@bobbingwide
Copy link
Owner Author

When attempting to resolve the Site Logo problem I ended up with a logo size with a non-integer width

<!-- wp:site-logo {"width":319.090909090909} /--></div>

In the original header.html template part the width was 192. But appeared as 193 in the custom version of the header.html template part. The 09 recurring appeared when I tried to reduce the number from 193 to 192.

@bobbingwide
Copy link
Owner Author

The “Cannot read property: limitExceeded” message had already been raised as an Issue. I added my comment WordPress/gutenberg#32939

@bobbingwide
Copy link
Owner Author

I’ll have to change the query-loop override logic to work against post-template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant