Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement relevant parts of genesis-hm's custom.css #10

Open
1 of 4 tasks
bobbingwide opened this issue Jul 13, 2021 · 1 comment
Open
1 of 4 tasks

Implement relevant parts of genesis-hm's custom.css #10

bobbingwide opened this issue Jul 13, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Jul 13, 2021

In the genesis-hm theme I used custom.css to style certain content.
While the content is still being displayed using shortcodes some of this CSS remains relevant.
There are 516 lines in the current custom.css files

Requirements

  • Reduce CSS as much as possible
  • Rework shortcodes to use blocks

Proposed solution

  • Initially implement custom.css as is.
  • Determine the need for the CSS over time.
  • Either retain only the CSS that's necessary to maintain the original styling
  • or improve the styling to no longer require the CSS.
@bobbingwide
Copy link
Owner Author

bobbingwide commented Feb 25, 2022

Determine the need for the CSS over time.

I've started doing this. Writing a blog post to check the results. https://s.b/hm/what-do-i-need-in-custom-css/
I started with unused CSS of 96.5%. It's now down to just over 50%. A fair proportion of that is CSS comments.
Note: Some CSS is still marked with a red bar even when it's actually been used. To test coverage you need to hover and probably give the field focus as well.

Improving custom.css is probably not as important as eliminating the need for font icons from dashicons / genericons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant