Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Parallel Road Tool #18

Open
ST-Apps opened this issue Jun 10, 2018 · 0 comments
Open

Compatibility with Parallel Road Tool #18

ST-Apps opened this issue Jun 10, 2018 · 0 comments

Comments

@ST-Apps
Copy link

ST-Apps commented Jun 10, 2018

Hi there,
I'm the developer of Parallel Road Tool and I'd like to address a compatibility issue between Network Skins and my mod.

The reason why I'm posting here is because I'm not sure on how to handle that, and I'd like your opinion on this whole thing.

Basically, what happens is that we're both detouring the CreateSegment method, and my guess is that my detour "overwrites" yours as my mod is loaded after yours (probably because of its name).

This leads to your detour being called by mine, providing a stacktrace that your mod doesn't like.

We are discussing a basic solution here, and it requires your code to be changed with a small patch that allows our stacktrace.

Would you be interested in integrating our PR so that we can have both mods working together? Do you think that there's a way to fix this on our end so that you don't have to update yours?

Thanks.

@BadiBasso BadiBasso mentioned this issue Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant