Skip to content

Commit eb37930

Browse files
committed
Fix logic to ignore versions
1 parent f287725 commit eb37930

File tree

3 files changed

+3
-160
lines changed

3 files changed

+3
-160
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
- Consume stdout/stderr asynchronously and add timeout for shell execution (#1469)
77
- Fix logic to find msedgedriver from XML responses (#1510)
88
- Fix condition to check external connections in download logic
9+
- Fix logic to ignore versions
910

1011
### Changed
1112
- Changed log level for shell result to trace

src/main/java/io/github/bonigarcia/wdm/WebDriverManager.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1309,7 +1309,8 @@ protected String download(String driverVersion) throws IOException {
13091309

13101310
URL url;
13111311
Optional<URL> optionalURL = buildUrl(driverVersion);
1312-
if (!config.isAvoidExternalConnections() && optionalURL.isPresent()) {
1312+
if (!config.isAvoidExternalConnections() && optionalURL.isPresent()
1313+
&& config.getIgnoreVersions().isEmpty()) {
13131314
url = optionalURL.get();
13141315
downloadedDriverVersion = driverVersion;
13151316
} else {

src/test/java/io/github/bonigarcia/wdm/WebDriverManagerTest.java

Lines changed: 0 additions & 159 deletions
This file was deleted.

0 commit comments

Comments
 (0)