Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve sql package test coverage #2

Open
alespour opened this issue Jul 28, 2020 · 0 comments
Open

improve sql package test coverage #2

alespour opened this issue Jul 28, 2020 · 0 comments
Assignees
@alespour

Comments

@alespour
Copy link
Collaborator

alespour commented Jul 28, 2020 •
edited
Loading

Improve code coverage by using datasets with type info in tests. PR #231 merged to master. Now waiting for release.

2020-08-17: DATA-DOG/go-sqlmock 1.5.0 with column metadata released

I guess it is better we wait for at least influxdata#3116 PR merged (influxdata#3098 would be nice too), and then update parsing tests for all DBs in single PR.
@alespour alespour self-assigned this Jul 28, 2020
@alespour alespour changed the title improve sql package coverage improve sql package test coverage Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alespour alespour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alespour