check alias with new user data

Instead of breaking a bunch of existing tests...
bookwyrm-social · Sep 8, 2024 · 1a93ba0 · 1a93ba0
1 parent ed55e05
commit 1a93ba0
Show file tree

Hide file tree

Showing 4 changed files with 55 additions and 22 deletions.
diff --git a/bookwyrm/tests/activitypub/test_base_activity.py b/bookwyrm/tests/activitypub/test_base_activity.py
@@ -46,11 +46,16 @@ def setUp(self):
         # don't try to load the user icon
         del self.userdata["icon"]
 
+        remote_datafile = pathlib.Path(__file__).parent.joinpath(
+            "../data/ap_user_external.json"
+        )
+        self.remote_userdata = json.loads(remote_datafile.read_bytes())
+        del self.remote_userdata["icon"]
+
         alias_datafile = pathlib.Path(__file__).parent.joinpath(
             "../data/ap_user_aliased.json"
         )
         self.alias_userdata = json.loads(alias_datafile.read_bytes())
-        # don't try to load the user icon
         del self.alias_userdata["icon"]
 
         image_path = pathlib.Path(__file__).parent.joinpath(
@@ -117,13 +122,6 @@ def test_resolve_remote_id(self, *_):
             status=200,
         )
 
-        responses.add(
-            responses.GET,
-            "https://example.com/user/moose",
-            json=self.alias_userdata,
-            status=200,
-        )
-
         with patch("bookwyrm.models.user.set_remote_server.delay"):
             result = resolve_remote_id(
                 "https://example.com/user/mouse", model=models.User
@@ -148,25 +146,21 @@ def test_resolve_remote_alias(self, *_):
 
         responses.add(
             responses.GET,
-            "https://example.com/user/mouse",
-            json=self.userdata,
+            "https://example.com/user/ali",
+            json=self.remote_userdata,
             status=200,
         )
 
         with patch("bookwyrm.models.user.set_remote_server.delay"):
             result = resolve_remote_id(
-                "https://example.com/user/mouse", model=models.User
+                "https://example.com/user/moose", model=models.User
             )
         self.assertIsInstance(result, models.User)
-        self.assertEqual(result.name, "MOUSE?? MOUSE!!")
-        self.assertEqual(
-            models.User.objects.count(), 3
-        )  # created a new mouse plus the alias
-        alias = models.User.objects.last()  # moose
-        self.assertEqual(alias.name, "moose?? moose!!")  # check it's moose
-        self.assertEqual(
-            result.also_known_as.first(), alias
-        )  # moose is alias of new mouse
+        self.assertEqual(result.name, "moose?? moose!!")
+        self.assertEqual(models.User.objects.count(), 3)  # created moose plus the alias
+        alias = models.User.objects.last()
+        self.assertEqual(alias.name, "Ali As")
+        self.assertEqual(result.also_known_as.first(), alias)  # Ali is alias of Moose
 
     def test_to_model_invalid_model(self, *_):
         """catch mismatch between activity type and model type"""

diff --git a/bookwyrm/tests/data/ap_user.json b/bookwyrm/tests/data/ap_user.json
@@ -28,7 +28,6 @@
     },
     "bookwyrmUser": true,
     "manuallyApprovesFollowers": false,
-    "alsoKnownAs": ["https://example.com/user/moose"],
     "discoverable": false,
     "devices": "https://friend.camp/users/tripofmice/collections/devices",
     "tag": [],

diff --git a/bookwyrm/tests/data/ap_user_aliased.json b/bookwyrm/tests/data/ap_user_aliased.json
@@ -29,7 +29,7 @@
     "bookwyrmUser": true,
     "manuallyApprovesFollowers": false,
     "discoverable": false,
-    "alsoKnownAs": ["http://example.com/a/b"],
+    "alsoKnownAs": ["https://example.com/user/ali"],
     "devices": "",
     "tag": [],
     "icon": {

diff --git a/bookwyrm/tests/data/ap_user_external.json b/bookwyrm/tests/data/ap_user_external.json
@@ -0,0 +1,40 @@
+{
+    "@context": [
+        "https://www.w3.org/ns/activitystreams",
+        "https://w3id.org/security/v1",
+        {
+            "manuallyApprovesFollowers": "as:manuallyApprovesFollowers",
+            "schema": "http://schema.org#",
+            "PropertyValue": "schema:PropertyValue",
+            "value": "schema:value"
+        }
+    ],
+    "id": "https://example.com/user/ali",
+    "type": "Person",
+    "preferredUsername": "alias",
+    "name": "Ali As",
+    "inbox": "https://example.com/user/ali/inbox",
+    "outbox": "https://example.com/user/ali/outbox",
+    "followers": "https://example.com/user/ali/followers",
+    "following": "https://example.com/user/ali/following",
+    "summary": "",
+    "publicKey": {
+        "id": "https://example.com/user/ali/#main-key",
+        "owner": "https://example.com/user/ali",
+        "publicKeyPem": "-----BEGIN PUBLIC KEY-----\nMIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC6QisDrjOQvkRo/MqNmSYPwqtt\nCxg/8rCW+9jKbFUKvqjTeKVotEE85122v/DCvobCCdfQuYIFdVMk+dB1xJ0iPGPg\nyU79QHY22NdV9mFKA2qtXVVxb5cxpA4PlwOHM6PM/k8B+H09OUrop2aPUAYwy+vg\n+MXyz8bAXrIS1kq6fQIDAQAB\n-----END PUBLIC KEY-----"
+    },
+    "endpoints": {
+        "sharedInbox": "https://example.com/inbox"
+    },
+    "bookwyrmUser": true,
+    "manuallyApprovesFollowers": false,
+    "alsoKnownAs": [],
+    "discoverable": false,
+    "devices": "",
+    "tag": [],
+    "icon": {
+        "type": "Image",
+        "mediaType": "image/png",
+        "url": "https://example.com/images/avatars/ALIAS-2-crop-50.png"
+    }
+}