fix illegal values in redis jobs #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. populate_streams_get_audience This tries to set status_reply_parent_privacy as None if there is no status.reply_parent, but None is not a valid value for privacy. This doesn't appear to be breaking anything but does result in a lot of error messages in the logs. I have set this to equal the original status.privacy - this won't realy have any effect since it only happens when there is no parent, however we could set this to "direct" if we want to be highly cautious. 2. rerank_user_task Again, this doesn't seem to caused major issues, but is throwing errors if the user in question no longer exists for some reason. This commit checks whether 'user' exists before attempting to rerank.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
populate_streams_get_audienceThis function tries to set status_reply_parent_privacy as
Noneif there is no status.reply_parent, butNoneis not a valid value for privacy. This doesn't appear to be breaking anything but does result in a lot of error messages in the logs. I have set the value to equal the originalstatus.privacy- this won't really have any effect since it only happens when there is no parent, however we could set this to "direct" if we want to be highly cautious.rerank_user_taskAgain, this doesn't seem to caused major issues, but is throwing errors if the user in question no longer exists for some reason. This commit checks whether
userexists before attempting to rerank.