Use ornament quotations #2999
Closed
Use ornament quotations #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dato
force-pushed
the
ornament_quotes
branch
3 times, most recently
from
f9c5844
to
7380a9d
Compare
dato
changed the title
pure_content
The result is visually similar to what the web UI uses, and avoids any ambiguity with common quote characters used by the quotation itself. The characters introduced are: - HEAVY DOUBLE COMMA QUOTATION MARK ORNAMENT U+275E - HEAVY DOUBLE TURNED COMMA QUOTATION MARK ORNAMENT U+275D
dato
force-pushed
the
ornament_quotes
branch
from
7380a9d
to
eaba99e
Compare
dato
added a commit
to dato/bookwyrm
that referenced
this pull request
Sep 25, 2023
|
Closing this because it probably makes things worse for screen readers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result is visually similar to what the web UI uses, and
avoids any ambiguity with common quote characters used by the
quotation itself.
I would love to have this for visuals aspects on the Fediverse, but
I'm marking it as draft because I'm unsure whether this is 100%
accessible.