Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim search whitespace #3410

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Trim search whitespace #3410

merged 2 commits into from
Aug 12, 2024

Conversation

timothyjrogers
Copy link
Contributor

@timothyjrogers timothyjrogers commented Aug 11, 2024 •
edited
Loading

Description

This PR updates the search GET request handler and associated functions to trim leading and trailing whitespace from the query value (e.g. the ISBN).

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

N/A

Documentation

N/A

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@mouse-reeve
Copy link
Member

And with tests! Thank you!!

@mouse-reeve mouse-reeve merged commit cf753af into bookwyrm-social:main Aug 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim leading and trailing spaces in search
2 participants
@timothyjrogers @mouse-reeve