Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

크롱님 코드리뷰 기반 리팩토링 #199

Open
1 of 3 tasks
sbyeol3 opened this issue Dec 13, 2020 · 3 comments
Open
1 of 3 tasks

크롱님 코드리뷰 기반 리팩토링 #199

sbyeol3 opened this issue Dec 13, 2020 · 3 comments
Assignees
@sbyeol3 @jinhyukoo @ramram1048 @Front-line-dev
Labels
refactor 🚀
Milestone
5주차

Comments

@sbyeol3
Copy link
Collaborator

sbyeol3 commented Dec 13, 2020 •
edited by Front-line-dev
Loading

💁 설명

크롱님이 남겨주신 4주차 코드리뷰를 참고하여
코드를 리팩토링 해봅시다~

📑 체크리스트

구현해야 하는 이슈 체크리스트

  • 사이드이펙트는 없어야 한다.
  • 헝가리안 표기법
  • 멤버 변수 대신 메소드 사용

🚧 주의 사항

이슈를 구현할 때 유의깊게 살펴볼 사항

  • 주의 사항 1
  • 주의 사항 2
@sbyeol3 sbyeol3 added this to the 5주차 milestone Dec 13, 2020
@Front-line-dev
Copy link
Collaborator

이거는 정말 중요한데 모르고 있었네요
#191 (comment)

@Front-line-dev
Copy link
Collaborator

메소드를 전부 작성하면 코드가 길어져서 이렇게 했는데 어떻게 할지 여쭈어보고 싶네요
#191 (comment)

sbyeol3 added a commit that referenced this issue Dec 17, 2020
@sbyeol3
Refacotr : 헝가리안 표기법 적용 (#199)
ec2d76a 
- 크롱님 코드리뷰 : 함수가 아닌 변수는 is~가 아니라 b~로 해라!
@Front-line-dev
Copy link
Collaborator

#282

Front-line-dev added a commit that referenced this issue Dec 17, 2020
@Front-line-dev
Merge branch 'develop' into refactor/#199
385c9b3
Front-line-dev added a commit that referenced this issue Dec 17, 2020
@Front-line-dev
Merge pull request #282 from boostcamp-2020/refactor/#199
0e58a72 
헝가리안 표기법으로 리팩토링 + 빈 문자열을 닉네임으로 설정할 때 되돌리기
@ramram1048 ramram1048 reopened this Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbyeol3 sbyeol3

@jinhyukoo jinhyukoo

@ramram1048 ramram1048

@Front-line-dev Front-line-dev

Labels
refactor 🚀
Projects
None yet
Milestone
5주차
Development

No branches or pull requests
4 participants
@sbyeol3 @jinhyukoo @ramram1048 @Front-line-dev