Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming apply_member_pointer #136

Closed
ldionne opened this issue Apr 17, 2017 · 2 comments
Closed

Consider renaming apply_member_pointer #136

ldionne opened this issue Apr 17, 2017 · 2 comments
Labels
review wontfix

Comments

@ldionne
Copy link
Member

ldionne commented Apr 17, 2017

I think I'm struggling to understand what apply_member_pointer because of its name. Instead, I think something along the lines of make_member (the intent is that you're making a non-member signature into a member signature) might be more intuitive. Just a suggestion.
@badair badair added the review label Apr 18, 2017
@badair
Copy link
Collaborator

badair commented Apr 18, 2017

Relates to #110

@badair
Copy link
Collaborator

badair commented Apr 18, 2017

Thanks, Louis. You're right, this one is a bit weird.

@badair badair added the wontfix label Aug 2, 2021
@badair badair closed this as completed Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
review wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ldionne @badair