Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues with custom exceptions implementation #184

Closed
igaztanaga opened this issue Apr 19, 2021 · 0 comments
Closed

Issues with custom exceptions implementation #184

igaztanaga opened this issue Apr 19, 2021 · 0 comments

Comments

@igaztanaga
Copy link
Member

igaztanaga commented Apr 19, 2021 •
edited
Loading

As reported in issue #183, there are implementation issues:

  • Needless #ifdef BOOST_CONTAINER_USE_STD_EXCEPTIONS checks in the throw_* functions
  • Likely visibility issues when throwing/catching such exceptions over DSO boundaries due to -fvisibility=hidden being the default (now) and no BOOST_SYMBOL_EXPORT or similar on the class
  • docs were forgotten to be updated:
  • If BOOST_NO_EXCEPTIONS is NOT defined std::logic_error(str) is thrown.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igaztanaga