Removing old uBLAS from the tensor #162
Unanswered
amitsingh19975
asked this question in
Proposal
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Since we are going to move towards a new implementation of matrix and vector, why are we still hanging on to them in the tensor?
We should purge them and also remove the use of
ublas_expression
, which makes it impossible to make the constructor oftensor_expression
,constexpr
becauseublas_expression
's constructors are notconstexpr
.If we want to construct tensors from the old APIs, we can create separate free functions in some header files that will construct the tensor for the user. It will help us from not polluting the tensor class.
Also, it allows us to create new and more robust APIs. Furthermore, it is easier to maintain because of decoupling. Otherwise, we have to implement it multiple times for each specialized tensor class.
Beta Was this translation helpful? Give feedback.
All reactions