Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable explicit conversion for quantities of unrelated units #37

Closed
wants to merge 1 commit into from

Conversation

kaihowl
Copy link

@kaihowl kaihowl commented Feb 22, 2019

This fixes #36.

@kaihowl
Copy link
Author

kaihowl commented Feb 22, 2019

It seems that the windows builds are not running on a PR. It this on purpose? Should I look at them more closely?

@swatanabe
Copy link
Contributor

swatanabe commented Feb 22, 2019 via email

@kaihowl
Copy link
Author

kaihowl commented Feb 25, 2019

This solution was meant to work on C++03 as well. I do see that Travis does not like it anyway.

When I use the proposed solution by you, I assume that BOOST_NO_CXX11_DECLTYPE should be used to wrapped this then?

@swatanabe
Copy link
Contributor

swatanabe commented Feb 25, 2019 via email

@kaihowl
Copy link
Author

kaihowl commented Mar 7, 2019

How would you attach the template type alias in the C++11 version for require_conversion_factor to the conversion_helper template? If I attach it as a default template parameter argument to the class, I get an ambiguity for absolute units. If I attach it to the convert function, I cannot do SFINAE anymore for the require_conversion_helper as this is not the immediate context anymore where the substitution fails. I am stuck. (Yet again.)

@swatanabe
Copy link
Contributor

swatanabe commented Mar 7, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is_constructible has unexpected results
3 participants