Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch boostlook.css from the correct branch (master or develop) #332

Closed
julioest opened this issue Sep 13, 2024 · 3 comments
Closed

Fetch boostlook.css from the correct branch (master or develop) #332

julioest opened this issue Sep 13, 2024 · 3 comments
Assignees

Comments

@julioest
Copy link
Collaborator

julioest commented Sep 13, 2024

The fetchBoostlookCss function currently always downloads boostlook.css from the master branch, regardless of which branch is being built. This can lead to inconsistencies when building from the develop branch, as the styles may not match the codebase.

We need to update the function to dynamically determine the current Git branch (master or develop) and fetch boostlook.css from the corresponding branch in the boostlook repository. This will ensure consistency between the code and styles across different branches.

reference #331 (comment)

@alandefreitas
Copy link
Member

Do you have any suggestions on how this should be implemented? The gulp task finds and runs git to identify the current branch? Or would it be another command line option to set what branch of boostlook we want?

@alandefreitas
Copy link
Member

Or would it be another command line option to set what branch of boostlook we want?

That's the correct solution because you are concerned about the preview to AWS and the website. So, the build task can have the option to choose the branch, and we would choose to develop or master accordingly in CI before the automation uploads it to AWS.

@alandefreitas
Copy link
Member

resolved: #335

I'm sorry I forgot to tag the issue on the commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants