You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The fetchBoostlookCss function currently always downloads boostlook.css from the master branch, regardless of which branch is being built. This can lead to inconsistencies when building from the develop branch, as the styles may not match the codebase.
We need to update the function to dynamically determine the current Git branch (master or develop) and fetch boostlook.css from the corresponding branch in the boostlook repository. This will ensure consistency between the code and styles across different branches.
Do you have any suggestions on how this should be implemented? The gulp task finds and runs git to identify the current branch? Or would it be another command line option to set what branch of boostlook we want?
Or would it be another command line option to set what branch of boostlook we want?
That's the correct solution because you are concerned about the preview to AWS and the website. So, the build task can have the option to choose the branch, and we would choose to develop or master accordingly in CI before the automation uploads it to AWS.
The
fetchBoostlookCss
function currently always downloads boostlook.css from the master branch, regardless of which branch is being built. This can lead to inconsistencies when building from the develop branch, as the styles may not match the codebase.We need to update the function to dynamically determine the current Git branch (master or develop) and fetch boostlook.css from the corresponding branch in the boostlook repository. This will ensure consistency between the code and styles across different branches.
reference #331 (comment)
The text was updated successfully, but these errors were encountered: