Move versions context population to BoostVersionMixin (#1500)

Author: daveoconnor

libraries/mixins.py

@@ -1,8 +1,11 @@
+from functools import partial
+
 import structlog
 from django.shortcuts import get_object_or_404
 from django.urls import reverse
 
 from libraries.constants import LATEST_RELEASE_URL_PATH_STR
+from libraries.models import Library
 from versions.models import Version
 
 logger = structlog.get_logger()
@@ -26,24 +29,49 @@ def get_context_data(self, **kwargs):
 
 
 class BoostVersionMixin:
-    def get_context_data(self, **kwargs):
-        context = super().get_context_data(**kwargs)
-        # todo: replace get_current_library_version on LibraryDetail with this +
-        #  prefetch_related
-        context.update(
+    def dispatch(self, request, *args, **kwargs):
+        if not self.extra_context:
+            self.extra_context = {}
+
+        if not self.extra_context.get("current_version"):
+            self.extra_context["current_version"] = Version.objects.most_recent()
+
+        self.extra_context.update(
             {
                 "version_str": self.kwargs.get("version_slug"),
                 "LATEST_RELEASE_URL_PATH_STR": LATEST_RELEASE_URL_PATH_STR,
             }
         )
-        if not context.get("current_version"):
-            context["current_version"] = Version.objects.most_recent()
-
-        if context["version_str"] == LATEST_RELEASE_URL_PATH_STR:
-            context["selected_version"] = context["current_version"]
-        elif context["version_str"]:
-            context["selected_version"] = get_object_or_404(
-                Version, slug=context["version_str"]
+        if self.extra_context["version_str"] == LATEST_RELEASE_URL_PATH_STR:
+            self.extra_context["selected_version"] = self.extra_context[
+                "current_version"
+            ]
+        elif self.extra_context["version_str"]:
+            self.extra_context["selected_version"] = get_object_or_404(
+                Version, slug=self.extra_context["version_str"]
             )
 
-        return context
+        version_path_kwargs = {
+            "release-detail": {},
+            "libraries-list": {
+                "filter_out_has_no_libraries": True,
+                "force_version_inclusion": self.extra_context["current_version"],
+            },
+            "library-detail": {
+                "flag_versions_without_library": partial(
+                    get_object_or_404, Library, slug=self.kwargs.get("library_slug")
+                )
+            },
+        }.get(self.request.resolver_match.view_name, {})
+        # we need this step to process any partials
+        processed_version_path_kwargs = {
+            key: (value() if callable(value) else value)
+            for key, value in version_path_kwargs.items()
+        }
+
+        self.extra_context["versions"] = Version.objects.get_dropdown_versions(
+            **processed_version_path_kwargs
+        )
+        # here we hack extra_context into the request so we can access for cookie checks
+        request.extra_context = self.extra_context
+        return super().dispatch(request, *args, **kwargs)

libraries/utils.py

@@ -142,7 +142,10 @@ def get_category(request):
 
 
 def determine_selected_boost_version(request_value, request):
-    valid_versions = Version.objects.get_dropdown_versions()
+    # use the versions in the request if they are available otherwise fall back to DB
+    valid_versions = getattr(request, "extra_context", {}).get(
+        "versions", Version.objects.get_dropdown_versions()
+    )
     version_slug = request_value or get_version_from_cookie(request)
     if version_slug in [v.slug for v in valid_versions] + [LATEST_RELEASE_URL_PATH_STR]:
         return version_slug

libraries/views.py

@@ -98,10 +98,6 @@ def get_queryset(self):
     def get_context_data(self, **kwargs):
         context = super().get_context_data(**self.kwargs)
         context["categories"] = self.get_categories(context["selected_version"])
-        context["versions"] = Version.objects.get_dropdown_versions(
-            filter_out_has_no_libraries=True,
-            force_version_inclusion=context["current_version"],
-        )
         # todo: add tests for sort order
         if self.kwargs.get("category_slug"):
             context["category"] = Category.objects.get(
@@ -225,9 +221,6 @@ def get_context_data(self, **kwargs):
         context = super().get_context_data(**kwargs)
         context["library_view_str"] = get_prioritized_library_view(self.request)
         # Get versions, flag when the current library isn't in each version
-        context["versions"] = Version.objects.get_dropdown_versions(
-            flag_versions_without_library=self.object
-        )
         context["LATEST_RELEASE_URL_PATH_NAME"] = LATEST_RELEASE_URL_PATH_STR
         if not self.object:
             raise Http404("No library found matching the query")

versions/views.py

@@ -47,7 +47,6 @@ def get_context_data(self, **kwargs):
             context["is_current_release"] = False
             return context
 
-        context["versions"] = Version.objects.get_dropdown_versions()
         downloads = obj.downloads.all().order_by("operating_system")
         context["downloads"] = {
             k: list(v)