Skip to content

Commit 3a4fb3e

Browse files
committed
And Rails 7 checks, plus remove unnecessary stunts in helper
1 parent dbb6b32 commit 3a4fb3e

File tree

3 files changed

+5
-27
lines changed

3 files changed

+5
-27
lines changed

test/bootstrap_fields_test.rb

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class BootstrapFieldsTest < ActionView::TestCase
2929
expected = <<~HTML
3030
<div class="mb-3">
3131
<label class="form-label" for="user_misc">Misc</label>
32-
<input class="form-control" id="user_misc" name="user[misc]" type="datetime" />
32+
<input class="form-control" id="user_misc" name="user[misc]" type="datetime-local" />
3333
</div>
3434
HTML
3535
assert_equivalent_html expected, @builder.datetime_field(:misc)

test/bootstrap_rich_text_area_test.rb

+4-14
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,13 @@ class BootstrapRichTextAreaTest < ActionView::TestCase
88
setup :setup_test_fixture
99

1010
test "rich text areas are wrapped correctly" do
11-
if ::Rails::VERSION::STRING >= "7"
12-
expected = nil
13-
with_stub_token do
14-
expected = <<~HTML
15-
<div class="mb-3">
16-
<label class="form-label" for="user_life_story">Life story</label>
17-
<input autocomplete="off" type="hidden" name="user[life_story]" id="user_life_story_trix_input_user"/>
18-
<trix-editor class="trix-content form-control" extra="extra arg" data-blob-url-template="http://test.host/rails/active_storage/blobs/redirect/:signed_id/:filename" data-direct-upload-url="http://test.host/rails/active_storage/direct_uploads" id="user_life_story" input="user_life_story_trix_input_user"/>
19-
</div>
20-
HTML
21-
end
22-
else
11+
expected = nil
12+
with_stub_token do
2313
expected = <<~HTML
2414
<div class="mb-3">
2515
<label class="form-label" for="user_life_story">Life story</label>
26-
<input #{autocomplete_attr} type="hidden" name="user[life_story]" id="user_life_story_trix_input_user"/>
27-
<trix-editor id="user_life_story" extra="extra arg" data-blob-url-template="#{data_blob_url_template}" data-direct-upload-url="http://test.host/rails/active_storage/direct_uploads" input="user_life_story_trix_input_user" class="trix-content form-control" />
16+
<input autocomplete="off" type="hidden" name="user[life_story]" id="user_life_story_trix_input_user"/>
17+
<trix-editor class="trix-content form-control" extra="extra arg" data-blob-url-template="http://test.host/rails/active_storage/blobs/redirect/:signed_id/:filename" data-direct-upload-url="http://test.host/rails/active_storage/direct_uploads" id="user_life_story" input="user_life_story_trix_input_user"/>
2818
</div>
2919
HTML
3020
end

test/test_helper.rb

-12
Original file line numberDiff line numberDiff line change
@@ -85,20 +85,8 @@ def assert_equivalent_html(expected, actual)
8585
def equivalent_with_looser_criteria?(expected, real, result)
8686
return result if result
8787

88-
if real.attr(:name) == "utf8"
89-
# Handle wrapped utf8 hidden field for Rails 4.2+
90-
expected = expected.child
91-
end
92-
9388
real.delete("data-disable-with")
9489

95-
if expected.is_a?(Nokogiri::XML::Attr) &&
96-
real.is_a?(Nokogiri::XML::Attr) &&
97-
expected.value == "datetime" &&
98-
real.value == "datetime-local"
99-
return true
100-
end
101-
10290
EquivalentXml.equivalent?(expected, real, element_order: true)
10391
end
10492

0 commit comments

Comments
 (0)