support string interpolation within Lists, nested Lists #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixed the "expected" and "got" argument order of the assertion.
|
Context on the commit I pushed: Our CI builds were intermittently failing due to the reload tests timing out. On my local machine, at a timeout of around 1300ms, it starts to time out frequently. I think 2000ms is a bit too close to this, so I upped the timeout to 5000ms. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements string interpolation within
Listand nestedLists.Includes tests! (ok, a test)
Gist describing the issue that prompted this PR:
https://gist.github.com/ramirez7/a963a5745f74d7e76b95ddb19615397d
resolves #21