Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some logging.debug does not lazily format #3319

Open
1 of 2 tasks
sunmy2019 opened this issue Dec 7, 2024 · 1 comment
Open
1 of 2 tasks

Some logging.debug does not lazily format #3319

sunmy2019 opened this issue Dec 7, 2024 · 1 comment
Labels
feature-request This issue requests a feature. logging p2 This is a standard priority issue

Comments

@sunmy2019
Copy link

Describe the feature

Currently, 22 over 144 logger.debug calls use f-strings. This can cause some unnecessary runtime costs.

https://docs.astral.sh/ruff/rules/logging-f-string/

I want to convert these to lazily formatted. I can open a PR if it is okay.

Use Case

It improves performance.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

1.35.76

Environment details (OS name and version, etc.)

Not applicable

@sunmy2019 sunmy2019 added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Dec 7, 2024
@tim-finnigan
Copy link
Contributor

Thanks for the feature request.

@tim-finnigan tim-finnigan added p2 This is a standard priority issue logging and removed needs-triage This issue or PR still needs to be triaged. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request This issue requests a feature. logging p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants