Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up rubocop violations #99

Open
ericfreese opened this issue Mar 22, 2017 · 0 comments
Open

Clean up rubocop violations #99

ericfreese opened this issue Mar 22, 2017 · 0 comments
Labels
cleanup

Comments

@ericfreese
Copy link
Member

See PRs #85 and #93.

From @virtuallybing:

The basic idea is that we’ve catalogued all of the Rubocop offenses that haven’t been looked at in the rubocop_todo.yml file so that we can decide what we want to do with cops one by one.

If you want to tackle a cop, delete that section from the rubocop_todo.yml file, then run Rubocop to see what offenses associated with that cop need to be addressed.

Some of the cops should be discussed with @rylanb and @ericfreese to determine whether or not we even want to enforce them in the first place, and if so, whether or not we want to relax its configuration.

This issue will be closed when rubocop_todo.yml is empty or deleted.
rylanb pushed a commit that referenced this issue May 28, 2018
@annaroyer @rylanb
Rubocop offenses may references #99 (#161)
184d2c7 
* regenerate rubocop_todo file to account for updates in inspected code

* Handle several rubocop syntax offenses and delete from rubocop_todo

* rebased with master and fix rubocop issue

* update each_key and each_value to single params

* fix conditional so it will not evaluate to nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericfreese