feat: Add campaign update functionality, direct submission on creation, and rejection reasons.

Author: 0xdevcollins

contracts/crowdfund_registry/src/contract.rs

@@ -129,6 +129,7 @@ impl CrowdfundRegistry {
         deadline: u64,
         milestone_descs: Vec<(String, u32)>,
         min_pledge: i128,
+        submit: bool,
     ) -> Result<u64, CrowdfundError> {
         owner.require_auth();
 
@@ -140,18 +141,7 @@ impl CrowdfundRegistry {
         }
 
         // Validate milestones: count 2-10, sum of pcts = 10000
-        let ms_count = milestone_descs.len();
-        if !(2..=10).contains(&ms_count) {
-            return Err(CrowdfundError::InvalidMilestones);
-        }
-        let mut pct_sum: u32 = 0;
-        for i in 0..ms_count {
-            let (_, pct) = milestone_descs.get(i).unwrap();
-            pct_sum += pct;
-        }
-        if pct_sum != 10000 {
-            return Err(CrowdfundError::InvalidMilestones);
-        }
+        Self::validate_milestones(&milestone_descs)?;
 
         let mut count: u64 = env
             .storage()
@@ -181,30 +171,24 @@ impl CrowdfundRegistry {
             env.invoke_contract(&escrow_addr, &sym(&env, "create_pool"), pool_args);
 
         // Store milestones decomposed
-        for i in 0..ms_count {
-            let (desc, pct) = milestone_descs.get(i).unwrap();
-            let milestone = Milestone {
-                id: i,
-                description: desc,
-                pct,
-                status: CrowdfundMilestoneStatus::Pending,
-            };
-            env.storage()
-                .persistent()
-                .set(&CrowdfundDataKey::CampaignMilestone(count, i), &milestone);
+        Self::set_milestones(&env, count, &milestone_descs);
+
+        let mut status = CampaignStatus::Draft;
+        if submit {
+            status = CampaignStatus::Submitted;
         }
 
         let campaign = Campaign {
             id: count,
             owner: owner.clone(),
             metadata_cid,
-            status: CampaignStatus::Draft,
+            status,
             funding_goal,
             current_funding: 0,
             asset,
             pool_id,
             deadline,
-            milestone_count: ms_count,
+            milestone_count: milestone_descs.len(),
             min_pledge,
             backer_count: 0,
             refund_progress: 0,
@@ -223,9 +207,65 @@ impl CrowdfundRegistry {
         }
         .publish(&env);
 
+        if submit {
+            CampaignSubmittedForReview { id: count }.publish(&env);
+        }
+
         Ok(count)
     }
 
+    pub fn update_campaign(
+        env: Env,
+        campaign_id: u64,
+        metadata_cid: String,
+        funding_goal: i128,
+        asset: Address,
+        deadline: u64,
+        milestone_descs: Vec<(String, u32)>,
+        min_pledge: i128,
+    ) -> Result<(), CrowdfundError> {
+        let key = CrowdfundDataKey::Campaign(campaign_id);
+        let mut campaign: Campaign = env
+            .storage()
+            .persistent()
+            .get(&key)
+            .ok_or(CrowdfundError::CampaignNotFound)?;
+
+        campaign.owner.require_auth();
+
+        if campaign.status != CampaignStatus::Draft {
+            return Err(CrowdfundError::NotDraft);
+        }
+
+        if funding_goal <= 0 {
+            return Err(CrowdfundError::AmountNotPositive);
+        }
+        if deadline <= env.ledger().timestamp() {
+            return Err(CrowdfundError::DeadlinePassed);
+        }
+
+        Self::validate_milestones(&milestone_descs)?;
+        Self::set_milestones(&env, campaign_id, &milestone_descs);
+
+        campaign.metadata_cid = metadata_cid;
+        campaign.funding_goal = funding_goal;
+        campaign.asset = asset;
+        campaign.deadline = deadline;
+        campaign.milestone_count = milestone_descs.len();
+        campaign.min_pledge = min_pledge;
+
+        env.storage().persistent().set(&key, &campaign);
+        Self::extend_persistent_ttl(&env, &key);
+
+        crate::events::CampaignUpdated {
+            id: campaign_id,
+            funding_goal,
+        }
+        .publish(&env);
+
+        Ok(())
+    }
+
     // ========================================================================
     // GOVERNANCE: APPROVAL WORKFLOW
     // Draft → Submitted → Validated → Campaigning
@@ -309,7 +349,11 @@ impl CrowdfundRegistry {
         Ok(session_id)
     }
 
-    pub fn reject_campaign(env: Env, campaign_id: u64) -> Result<(), CrowdfundError> {
+    pub fn reject_campaign(
+        env: Env,
+        campaign_id: u64,
+        reason: String,
+    ) -> Result<(), CrowdfundError> {
         let admin = Self::require_admin(&env)?;
         admin.require_auth();
 
@@ -328,7 +372,7 @@ impl CrowdfundRegistry {
         campaign.vote_session_id = None;
         env.storage().persistent().set(&key, &campaign);
 
-        CampaignRejected { id: campaign_id }.publish(&env);
+        CampaignRejected { id: campaign_id, reason }.publish(&env);
         Ok(())
     }
 
@@ -985,4 +1029,38 @@ impl CrowdfundRegistry {
             .get(&CrowdfundDataKey::GovernanceVoting)
             .expect("not initialized")
     }
+
+    fn validate_milestones(milestone_descs: &Vec<(String, u32)>) -> Result<(), CrowdfundError> {
+        let ms_count = milestone_descs.len();
+        if !(2..=10).contains(&ms_count) {
+            return Err(CrowdfundError::InvalidMilestones);
+        }
+        let mut pct_sum: u32 = 0;
+        for i in 0..ms_count {
+            let (_, pct) = milestone_descs.get(i).unwrap();
+            pct_sum += pct;
+        }
+        if pct_sum != 10000 {
+            return Err(CrowdfundError::InvalidMilestones);
+        }
+        Ok(())
+    }
+
+    fn set_milestones(env: &Env, campaign_id: u64, milestone_descs: &Vec<(String, u32)>) {
+        for i in 0..milestone_descs.len() {
+            let (desc, pct) = milestone_descs.get(i).unwrap();
+            let milestone = Milestone {
+                id: i,
+                description: desc,
+                pct,
+                status: CrowdfundMilestoneStatus::Pending,
+            };
+            env.storage()
+                .persistent()
+                .set(
+                    &CrowdfundDataKey::CampaignMilestone(campaign_id, i),
+                    &milestone,
+                );
+        }
+    }
 }

contracts/crowdfund_registry/src/events/mod.rs

@@ -1,4 +1,4 @@
-use soroban_sdk::{contractevent, Address, BytesN};
+use soroban_sdk::{contractevent, Address, BytesN, String};
 
 #[contractevent]
 #[derive(Clone, Debug, Eq, PartialEq)]
@@ -109,6 +109,15 @@ pub struct CampaignApproved {
 pub struct CampaignRejected {
     #[topic]
     pub id: u64,
+    pub reason: String,
+}
+
+#[contractevent]
+#[derive(Clone, Debug, Eq, PartialEq)]
+pub struct CampaignUpdated {
+    #[topic]
+    pub id: u64,
+    pub funding_goal: i128,
 }
 
 #[contractevent]

contracts/crowdfund_registry/src/tests/mod.rs

@@ -110,6 +110,7 @@ fn test_create_campaign() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     assert_eq!(cid, 1);
@@ -132,6 +133,7 @@ fn test_governance_flow() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     assert_eq!(t.client.get_campaign(&cid).status, CampaignStatus::Draft);
@@ -176,13 +178,70 @@ fn test_reject_campaign() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     t.client.submit_for_review(&cid);
-    t.client.reject_campaign(&cid);
+    t.client.reject_campaign(&cid, &String::from_str(&t.env, "Need more detail"));
     assert_eq!(t.client.get_campaign(&cid).status, CampaignStatus::Draft);
 }
 
+#[test]
+fn test_create_and_submit_campaign() {
+    let t = setup();
+    let owner = t.admin.clone();
+
+    let cid = t.client.create_campaign(
+        &owner,
+        &String::from_str(&t.env, "Instant Submit"),
+        &10000i128,
+        &t.token_addr,
+        &(t.env.ledger().timestamp() + 86400),
+        &make_milestones(&t.env),
+        &100i128,
+        &true,
+    );
+
+    assert_eq!(t.client.get_campaign(&cid).status, CampaignStatus::Submitted);
+}
+
+#[test]
+fn test_update_campaign() {
+    let t = setup();
+    let owner = t.admin.clone();
+
+    let cid = t.client.create_campaign(
+        &owner,
+        &String::from_str(&t.env, "Draft"),
+        &10000i128,
+        &t.token_addr,
+        &(t.env.ledger().timestamp() + 86400),
+        &make_milestones(&t.env),
+        &100i128,
+        &false,
+    );
+
+    let new_goal = 20000i128;
+    let mut new_ms = Vec::new(&t.env);
+    new_ms.push_back((String::from_str(&t.env, "Phase 1"), 5000u32));
+    new_ms.push_back((String::from_str(&t.env, "Phase 2"), 5000u32));
+
+    t.client.update_campaign(
+        &cid,
+        &String::from_str(&t.env, "Updated"),
+        &new_goal,
+        &t.token_addr,
+        &(t.env.ledger().timestamp() + 90000),
+        &new_ms,
+        &200i128,
+    );
+
+    let campaign = t.client.get_campaign(&cid);
+    assert_eq!(campaign.funding_goal, new_goal);
+    assert_eq!(campaign.milestone_count, 2);
+    assert_eq!(campaign.min_pledge, 200);
+}
+
 #[test]
 fn test_full_lifecycle() {
     let t = setup();
@@ -203,6 +262,7 @@ fn test_full_lifecycle() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     // Advance through governance flow
@@ -252,6 +312,7 @@ fn test_failed_campaign_refund() {
         &deadline,
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     // Advance through governance flow
@@ -296,6 +357,7 @@ fn test_cancel_campaign() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     // Advance through governance flow
@@ -331,6 +393,7 @@ fn test_reject_milestone() {
         &(t.env.ledger().timestamp() + 86400),
         &make_milestones(&t.env),
         &100i128,
+        &false,
     );
 
     // Advance through governance flow
@@ -376,6 +439,7 @@ fn test_invalid_milestones_rejected() {
         &(t.env.ledger().timestamp() + 86400),
         &bad_ms,
         &100i128,
+        &false,
     );
     assert!(result.is_err());
 }

contracts/crowdfund_registry/test_snapshots/tests/test_cancel_campaign.1.json

@@ -267,6 +267,9 @@
                 },
                 {
                   "i128": "100"
+                },
+                {
+                  "bool": false
                 }
               ]
             }