-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
I was doing some cpp stuff and stumbled upon this:
Obi2021Rework/src/main/java/frc/robot/sensors/Limelight.java
Lines 28 to 45 in 7b97288
| public LedMode getLedMode(){ | |
| int mode_num = table.getEntry("ledMode").getNumber(0).intValue(); | |
| if (mode_num == 0) { | |
| return LedMode.ledPipeline; | |
| } | |
| else if (mode_num == 1) { | |
| return LedMode.ledOff; | |
| } | |
| else if (mode_num == 1) { | |
| return LedMode.ledBlink; | |
| } | |
| else if (mode_num == 2) { | |
| return LedMode.ledOn; | |
| } | |
| return LedMode.ledOff; | |
| } |
It seems like either the value for ledOff, or the value for ledBlink must be wrong.
Also, should 0 be the default value supplied to getNumber? I don't know what ledPipeline is for, but if we're returning ledOff as our fallback, it seems like it would make sense for that to be the default too.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels