Skip to content

Limelight: getLedMode seems to be implemented incorrectly #11

@apppppppple

Description

@apppppppple

I was doing some cpp stuff and stumbled upon this:

public LedMode getLedMode(){
int mode_num = table.getEntry("ledMode").getNumber(0).intValue();
if (mode_num == 0) {
return LedMode.ledPipeline;
}
else if (mode_num == 1) {
return LedMode.ledOff;
}
else if (mode_num == 1) {
return LedMode.ledBlink;
}
else if (mode_num == 2) {
return LedMode.ledOn;
}
return LedMode.ledOff;
}

It seems like either the value for ledOff, or the value for ledBlink must be wrong.

Also, should 0 be the default value supplied to getNumber? I don't know what ledPipeline is for, but if we're returning ledOff as our fallback, it seems like it would make sense for that to be the default too.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions