New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be an else if #10

Open

ghost opened this issue Oct 11, 2020 · 0 comments

ghost commented Oct 11, 2020

modern_js_udemy_projects/numberguesser/app.js

Line 42 in 2075a62

}

This should be an else if. The way the code is now, you bypass your validation logic entirely. Will submit a PR shortly.

ghost mentioned this issue

Fix: Refactored to add missing validator #11

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment