Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline for voxel meshes #9

Open
chr-engwer opened this issue Sep 17, 2020 · 3 comments
Open

Improve pipeline for voxel meshes #9

chr-engwer opened this issue Sep 17, 2020 · 3 comments

Comments

@chr-engwer
Copy link
Contributor

You are using hex-meshes mainly to represent voxel meshes.

In this case you should be able to use some improvements:

  1. it might be better to use the sub-entity center search instead of the normal projection, as you have a structured (voxel) mesh
  2. instead of writing an unstructured grid file for a structured grid it would be more appropriate to go for the structured grid and the filter cells using dune-subgrid, like we do it for node shift meshes (where we also start with the voxel mesh).
@juangpc
Copy link
Contributor

juangpc commented Sep 17, 2020

What implications would this have in the future?
I would prefer (from a limited understanding) the unstructured grid options even if it requires more memory/computation-time. When dealing with mri->mesh libraries we cannot limit our work to those libraries that generate a structured grid.
Or perhaps I'n not really understanding the point?

@chr-engwer
Copy link
Contributor Author

You should distinguish between

  • unstructured tet meshes
  • voxel meshes
  • voxel meshes with node-shift
    and potentially in the future
  • unstructured hex meshes

The unstructured hex mesh is currently used, but it imposes more costs. I don't suggest to remove this code path. The proposal is to add an improved code path for voxel meshes.

@juangpc
Copy link
Contributor

juangpc commented Sep 18, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants