Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate resources in included #24

Open
burgessl opened this issue Oct 28, 2016 · 0 comments
Open

Duplicate resources in included #24

burgessl opened this issue Oct 28, 2016 · 0 comments
Labels
bug

Comments

@burgessl
Copy link
Contributor

It is possible to get the same resource twice in the included list if two different instances exist in the same object graph (e.g semantically the same object but not the same instance in memory).

It feels like a sensible fix would be to use the type & id to ensure only one representation of each object is included even if multiple instances exist in the object graph. I ran into this while fixing #20 and have implemented this fix in the pull request for #20
@burgessl burgessl mentioned this issue Oct 28, 2016
Merged
@burgessl burgessl changed the title Duplicate resources can in included Duplicate resources in included Oct 28, 2016
@brainwipe brainwipe added the bug label Nov 10, 2016
brainwipe added a commit that referenced this issue Feb 16, 2017
@brainwipe
Merge pull request #23 from burgessl/RelationshipNames
7d3ea94 
Fix #20 and #24 (use relationship names in include and prevent duplicate resources in included)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brainwipe @burgessl