Make standalone tests actually standalone #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Could you merge the latest HEAD onto this branch + update the newly added tests from #29? Then I can merge the whole lot :) |
closes bramus#24 Standalone tests were all using instances of Specificity instead of the actual standalone functions. Removed all the `Specificity.` prefixes after which the tests still run successfully.
bartveneman
force-pushed
the
fix-standalone-tests
branch
from
0a54006 to
a6d6248
Compare
|
FYI: In hindsight I realized this standalone test was not actually testing if the standalone exports work or not, as they imported the files directly. They also duplicated a bunch of tests that get run against the built file. As a result I have updated the standalone test in e57cb88 so that it actually tests if the subpath exports do export the correct set of functions. Their functionality is not tested in that file, as that’s a responsibility of the other test that uses the built asset for its tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24
Standalone tests were all using instances of Specificity instead of the actual standalone functions. Removed all the
Specificity.prefixes after which the tests still run successfully.