New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check prefs when setting greaselion::REWARDS #48

Open

Miyayes opened this issue Feb 21, 2021 · 0 comments

Assignees

Collaborator

Miyayes commented Feb 21, 2021

Description

Currently, we set 'rewards-enabled' to TRUE, without consulting prefs at https://github.com/brave/brave-core/blob/5769e9dfb04898f8e750828fe0581d41322cd0d8/components/brave_rewards/browser/rewards_service_impl.cc#L1321, per @jonathansampson.

This is related to brave/brave-browser#14277.

Solution

Should check prefs as to whether Rewards has actually been enabled.

emerick self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment