Sphinx pyref regression test: handle different output of some Sphinx versions

Author: brechtm

tests_regression/helpers/regression.py

@@ -166,11 +166,12 @@ def render_doctree(doctree, out_dir, out_filename, reference_path,
     verify_output(out_filename, output_dir, reference_path)
 
 
-def verify_output(out_filename, output_dir, reference_path):
-    pdf_filename = '{}.pdf'.format(out_filename)
+def verify_output(test_name, output_dir, reference_path, alt=None):
+    pdf_filename = f'{test_name}.pdf'
+    ref_pdf_filename = f'{test_name}{'_' + alt if alt else ''}.pdf'
     (ref_anchors, ref_links, ref_superfluous_anchors,
      ref_badlinks, ref_badoutlinelinks, ref_urls, ref_badurls, ref_outlines) = \
-        check_pdf_links(reference_path / pdf_filename)
+        check_pdf_links(reference_path / ref_pdf_filename)
     with in_directory(output_dir):
         (anchors, links, superfluous_anchors,
          badlinks, badoutlinelinks, urls, badurls, outlines) = \
@@ -181,7 +182,7 @@ def verify_output(out_filename, output_dir, reference_path):
         pytest.assume(diff_outlines(ref_outlines, outlines),
                       "Outlines mismatch!          (ref | new)\n"
                       + format_outlines(ref_outlines, outlines))
-        if not diff_pdf(reference_path / pdf_filename, pdf_filename):
+        if not diff_pdf(reference_path / ref_pdf_filename, pdf_filename):
             pytest.fail('The generated PDF is different from the reference '
                         'PDF.\nGenerated files can be found in {}'
                         .format(output_dir))