From e9e07088cdb728d710bd309e5a1bcc91d371bce0 Mon Sep 17 00:00:00 2001 From: tatthangcntt Date: Wed, 11 Sep 2024 16:19:48 +0700 Subject: [PATCH 1/3] Fix issue: can't here RBT when make call with out SDP --- src/components/CallVoices.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/CallVoices.tsx b/src/components/CallVoices.tsx index 8ac23472f..6ab3e1a61 100644 --- a/src/components/CallVoices.tsx +++ b/src/components/CallVoices.tsx @@ -16,8 +16,8 @@ export const CallVoices = observer(() => { void cs.calls.map(_ => _.callkeepUuid) const oc = cs.getOngoingCall() - const isOutgoingProgress = - oc && !oc.incoming && !oc.answered && oc.sessionStatus === 'progress' + const isOutgoing = oc && !oc.incoming && !oc.answered + const isOutgoingProgress = isOutgoing && oc.sessionStatus === 'progress' // when receive a 18x response (usually 180 or 183) with SDP // don't play the local RBT, but the audio data in the RTP packets @@ -26,8 +26,8 @@ export const CallVoices = observer(() => { return ( <> - {isOutgoingProgress && - (playEarlyMedia ? ( + {isOutgoing && + (isOutgoingProgress && playEarlyMedia && oc.earlyMedia? ( ) : ( <> From 548767c692fbd9c9ee5cd6d89b4c0986261045ec Mon Sep 17 00:00:00 2001 From: tatthangcntt Date: Wed, 18 Sep 2024 15:34:55 +0700 Subject: [PATCH 2/3] update format code --- src/components/CallVoices.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/CallVoices.tsx b/src/components/CallVoices.tsx index 6ab3e1a61..ee9102bcc 100644 --- a/src/components/CallVoices.tsx +++ b/src/components/CallVoices.tsx @@ -16,7 +16,7 @@ export const CallVoices = observer(() => { void cs.calls.map(_ => _.callkeepUuid) const oc = cs.getOngoingCall() - const isOutgoing = oc && !oc.incoming && !oc.answered + const isOutgoing = oc && !oc.incoming && !oc.answered const isOutgoingProgress = isOutgoing && oc.sessionStatus === 'progress' // when receive a 18x response (usually 180 or 183) with SDP @@ -27,7 +27,7 @@ export const CallVoices = observer(() => { return ( <> {isOutgoing && - (isOutgoingProgress && playEarlyMedia && oc.earlyMedia? ( + (isOutgoingProgress && playEarlyMedia && oc.earlyMedia ? ( ) : ( <> From f2c5b0bb9d1053101ef4695df6494c3f15af50f6 Mon Sep 17 00:00:00 2001 From: Nam Nguyen Date: Mon, 7 Oct 2024 19:39:08 +0700 Subject: [PATCH 3/3] nam --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index c03607c68..fdd5e085d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -11,6 +11,7 @@ - Fix android it should answer call immediately with x_autoanswer (issue 908) - Fix it should display call duration correctly after manually allow Notification permissions (issue 918) - Fix it should load video when turning it on from a voice call (issue 934) +- Fix it should play RBT when make call without SDP (issue 964) #### 2.14.10