We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
Thank you so much for your cool module!
I have one suggestion about ngx_http_kafka_exit_worker. https://github.com/brg-liuwei/ngx_kafka_module/blob/master/ngx_http_kafka_module.c#L386
ngx_http_kafka_exit_worker
In my opinion, rd_kafka_poll should be done until rd_kafka_outq_len(main_conf->rk) > 0, in order to ensure kafka messages to be delivered before exit.
rd_kafka_poll
rd_kafka_outq_len(main_conf->rk) > 0
rd_kafka_poll(main_conf->rk, 0); while (rd_kafka_outq_len(main_conf->rk) > 0) { rd_kafka_poll(main_conf->rk, 100); } // TODO: rd_kafka_topic_destroy(each loc conf rkt ); rd_kafka_destroy(main_conf->rk);
The text was updated successfully, but these errors were encountered:
Great!
Would you please commit a pull request?
Sorry, something went wrong.
Thanks and done the pull request. #10
Merge pull request #10 from takaomag/spike_deliver_msg_at_exit
54531ba
Add rd_kafka_poll() at exit. See issue #9 for detail.
No branches or pull requests
Hi,
Thank you so much for your cool module!
I have one suggestion about
ngx_http_kafka_exit_worker
.https://github.com/brg-liuwei/ngx_kafka_module/blob/master/ngx_http_kafka_module.c#L386
In my opinion,
rd_kafka_poll
should be done untilrd_kafka_outq_len(main_conf->rk) > 0
, in order to ensure kafka messages to be delivered before exit.https://github.com/edenhill/librdkafka/blob/master/examples/rdkafka_example.c#L619
The text was updated successfully, but these errors were encountered: