Merge pull request #10 from brian-team:linter_changes

Linter changes

Author: mstimberg

src/QuantSI/__init__.py

@@ -3,7 +3,7 @@
 """
 
 # isort:skip_file
-from ._version import __version__
+from ._version import __version__ as __version__
 
 from .allunits import (
     # basic units
@@ -185,12 +185,52 @@
     Twatt,
 )
 
-from .fundamentalunits import *
-from .fundamentalunits import __all__ as fundamentalunits_all
-
-from .stdunits import *
-from .stdunits import __all__ as stdunits_all
+from .fundamentalunits import (
+    DimensionMismatchError,
+    get_or_create_dimension,
+    get_dimensions,
+    is_dimensionless,
+    have_same_dimensions,
+    in_unit,
+    in_best_unit,
+    Quantity,
+    Unit,
+    register_new_unit,
+    check_units,
+    is_scalar_type,
+    get_unit,
+)
 
+from .stdunits import (
+    mV,
+    mA,
+    uA,
+    nA,
+    pA,
+    pF,
+    uF,
+    nF,
+    nS,
+    uS,
+    mS,
+    ms,
+    us,
+    Hz,
+    kHz,
+    MHz,
+    cm,
+    cm2,
+    cm3,
+    mm,
+    mm2,
+    mm3,
+    um,
+    um2,
+    um3,
+    mM,
+    uM,
+    nM,
+)
 
 __all__ = [
     "pamp",
@@ -369,6 +409,47 @@
     "Mwatt",
     "Gwatt",
     "Twatt",
+    # from fundamentalunits
+    "DimensionMismatchError",
+    "get_or_create_dimension",
+    "get_dimensions",
+    "is_dimensionless",
+    "have_same_dimensions",
+    "in_unit",
+    "in_best_unit",
+    "Quantity",
+    "Unit",
+    "register_new_unit",
+    "check_units",
+    "is_scalar_type",
+    "get_unit",
+    # from stdunits
+    "mV",
+    "mA",
+    "uA",
+    "nA",
+    "pA",
+    "pF",
+    "uF",
+    "nF",
+    "nS",
+    "uS",
+    "mS",
+    "ms",
+    "us",
+    "Hz",
+    "kHz",
+    "MHz",
+    "cm",
+    "cm2",
+    "cm3",
+    "mm",
+    "mm2",
+    "mm3",
+    "um",
+    "um2",
+    "um3",
+    "mM",
+    "uM",
+    "nM",
 ]
-__all__.extend(fundamentalunits_all)
-__all__.extend(stdunits_all)

src/QuantSI/fundamentalunits.py

@@ -2551,8 +2551,8 @@ def new_f(*args, **kwds):
                 if (
                     k in au
                     and not isinstance(newkeyset[k], str)
-                    and not newkeyset[k] is None
-                    and not au[k] is None
+                    and newkeyset[k] is not None
+                    and au[k] is not None
                 ):
                     if au[k] in (bool, np.bool_):
                         if not isinstance(newkeyset[k], (bool, np.bool_)):
@@ -2565,7 +2565,7 @@ def new_f(*args, **kwds):
                             )
                             raise TypeError(error_message)
                     elif isinstance(au[k], str):
-                        if not au[k] in newkeyset:
+                        if au[k] not in newkeyset:
                             error_message = (
                                 f"Function '{f.__name__}' "
                                 "expected its argument to have the "
@@ -2644,7 +2644,7 @@ def new_f(*args, **kwds):
             new_f._return_unit = None
         else:
             new_f._return_unit = return_unit
-        if return_unit == bool:
+        if return_unit is bool:
             new_f._returns_bool = True
         else:
             new_f._returns_bool = False

src/version_helper.py

@@ -1,5 +1,3 @@
-from pdm.backend.hooks.version import SCMVersion
-
 def format_version(version) -> str:
     """
     Format the version number of the package. This function is only supposed to be