Skip to content

Commit 078067a

Browse files
committed
CI: remove duplicate jobs, improve comments
1 parent 01f5d71 commit 078067a

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/build.yml

+7-6
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,11 @@ jobs:
99
strategy:
1010
matrix:
1111
include:
12-
# Ruby 3.x on Ubuntu 22.04 LTS (latest at this time)
12+
# Ruby 3.x on Ubuntu 24.04 LTS
1313
- {os: ubuntu-24.04, ruby: 'head', db: mysql84}
1414
- {os: ubuntu-24.04, ruby: '3.4', db: mysql84}
1515

16-
# Ruby 3.x on Ubuntu 22.04 LTS (latest at this time)
16+
# Ruby 3.x on Ubuntu 22.04 LTS
1717
- {os: ubuntu-22.04, ruby: '3.4', db: mysql80}
1818
- {os: ubuntu-22.04, ruby: '3.3', db: mysql80}
1919
- {os: ubuntu-22.04, ruby: '3.2', db: mysql80}
@@ -30,6 +30,10 @@ jobs:
3030
- {os: ubuntu-20.04, ruby: '2.1', db: mysql80}
3131
- {os: ubuntu-20.04, ruby: '2.0', db: mysql80}
3232

33+
# MySQL 5.7 packages stopped after Ubuntu 18.04 Bionic
34+
# - {os: ubuntu-18.04, ruby: '2.7', db: mysql57}
35+
36+
# MariaDB LTS versions
3337
# db: on Linux, ci/setup.sh installs the specified packages
3438
# db: on MacOS, installs a Homebrew package use "[email protected]" to specify a version
3539

@@ -38,10 +42,6 @@ jobs:
3842
- {os: ubuntu-22.04, ruby: '2.7', db: mariadb10.11}
3943
- {os: ubuntu-22.04, ruby: '3.0', db: mariadb10.6}
4044
- {os: ubuntu-20.04, ruby: '2.7', db: mariadb10.6}
41-
- {os: ubuntu-20.04, ruby: '2.7', db: mysql80}
42-
43-
# MySQL 5.7 packages stopped after Ubuntu 18.04 Bionic
44-
# - {os: ubuntu-18.04, ruby: '2.7', db: mysql57}
4545

4646
# TODO - Windows CI
4747
# - {os: windows-2022, ruby: '3.2', db: mysql80}
@@ -52,6 +52,7 @@ jobs:
5252
- {os: macos-latest, ruby: '3.4', db: [email protected], ssl: openssl@3, allow-failure: true}
5353
- {os: macos-latest, ruby: '3.4', db: [email protected], ssl: openssl@3, allow-failure: true}
5454
- {os: macos-latest, ruby: '2.6', db: [email protected], ssl: [email protected], allow-failure: true}
55+
5556
# On the fail-fast: true, it cancels all in-progress jobs
5657
# if any matrix job fails, which we don't want.
5758
fail-fast: false

0 commit comments

Comments
 (0)