Skip to content

Commit d7d2eee

Browse files
davidsiawsodabrew
andauthored
CI: fixes and improvements (#1371)
* Add bigdecimal dependency, no longer installed by default in Ruby 3.4 * CI: remove Ubuntu 18.04 image because it doesn't exist anymore * CI: brew install zstd on MacOS Co-authored-by: Aaron Stone <[email protected]>
1 parent 15f8e6e commit d7d2eee

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

.github/workflows/build.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
- {os: ubuntu-22.04, ruby: '3.0', db: mariadb10.6}
3535
- {os: ubuntu-20.04, ruby: '2.7', db: mariadb10.6}
3636
- {os: ubuntu-20.04, ruby: '2.7', db: mysql80}
37-
- {os: ubuntu-18.04, ruby: '2.7', db: mysql57}
37+
- {os: ubuntu-20.04, ruby: '2.7', db: mysql57}
3838

3939
# TODO - Windows CI
4040
# - {os: windows-2022, ruby: '3.2', db: mysql80}

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ Ruby runtime and MySQL client libraries are compiled with the same OpenSSL
107107
family, 1.0 or 1.1 or 3.0, since only one can be loaded at runtime.
108108

109109
``` sh
110-
$ brew install [email protected]
110+
$ brew install [email protected] zstd
111111
$ gem install mysql2 -- --with-openssl-dir=$(brew --prefix [email protected])
112112

113113
or

ci/setup.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ if [[ x$OSTYPE =~ ^xdarwin ]]; then
7070
done
7171

7272
brew info "$DB"
73-
brew install "$DB"
73+
brew install "$DB" zstd
7474
DB_PREFIX="$(brew --prefix "${DB}")"
7575
export PATH="${DB_PREFIX}/bin:${PATH}"
7676
export LDFLAGS="-L${DB_PREFIX}/lib"

mysql2.gemspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ Mysql2::GEMSPEC = Gem::Specification.new do |s|
2323

2424
s.metadata['msys2_mingw_dependencies'] = 'libmariadbclient'
2525

26-
s.add_runtime_dependency 'bigdecimal'
26+
s.add_dependency 'bigdecimal'
2727
end

0 commit comments

Comments
 (0)