Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Run cargo package for all supported targets before publishing #1879

Open
briansmith opened this issue Jan 3, 2024 · 0 comments
Open
Assignees

Comments

@briansmith
Copy link
Owner

cargo package by default builds the package for the default target, and this is what the current package job in CI does. However, this doesn't work well for us as we have many target-specific files, especially target-specific C and assembly/PerlAsm files.

Instead, we should recognize that a commit that is supposed to be the last one prior to a release, and run cargo package for every target for these commits, in addition to the normal test matrix, to ensure that the crate builds for all supported targets before publishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant