From 8cdae39e1af15b72d4c8e527c474089b28ac93a7 Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Tue, 5 Dec 2023 15:11:37 -0800 Subject: [PATCH 1/3] CI: Remove now-unneeded aarch64-apple-darwin workaround. --- .github/workflows/ci.yml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5b0cdc69..3041101d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -205,9 +205,6 @@ jobs: target: ${{ matrix.target }} toolchain: ${{ matrix.rust_channel }} - - if: ${{ matrix.target == 'aarch64-apple-darwin' }} - run: echo "DEVELOPER_DIR=/Applications/Xcode_12.2.app/Contents/Developer" >> $GITHUB_ENV - - if: ${{ matrix.target == 'aarch64-pc-windows-msvc' }} run: | echo "C:\Program Files (x86)\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\bin" >> $GITHUB_PATH @@ -272,9 +269,6 @@ jobs: target: ${{ matrix.target }} toolchain: ${{ matrix.rust_channel }} - - if: ${{ matrix.target == 'aarch64-apple-darwin' }} - run: echo "DEVELOPER_DIR=/Applications/Xcode_12.2.app/Contents/Developer" >> $GITHUB_ENV - - if: ${{ !contains(matrix.host_os, 'windows') }} run: | RING_COVERAGE=1 mk/cargo.sh +${{ matrix.rust_channel }} test --workspace -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} From 95bef91e5a34c383a49a8424923eeaf9eba0123d Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Tue, 5 Dec 2023 15:17:27 -0800 Subject: [PATCH 2/3] CI: Update use of GitHub Actions Actions to sync with *ring*. Update action/cache and action/checkout. Remove use of actions-rs. --- .github/workflows/ci.yml | 93 +++++++++++++--------------------------- 1 file changed, 29 insertions(+), 64 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3041101d..00aa4612 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -9,27 +9,21 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - toolchain: stable - profile: minimal - components: rustfmt - - uses: briansmith/actions-checkout@v2 + - run: rustup --version + + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false + - run: cargo fmt --all -- --check clippy: runs-on: ubuntu-22.04 steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - toolchain: stable - profile: minimal - components: clippy + - run: rustup --version - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false @@ -39,12 +33,9 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - toolchain: stable - profile: minimal + - run: rustup --version - - uses: briansmith/actions-cache@v2 + - uses: briansmith/actions-cache@v3 with: path: | ~/.cargo/bin/cargo-audit @@ -54,7 +45,7 @@ jobs: - run: cargo install cargo-audit --vers "0.13.1" - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false @@ -66,12 +57,9 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - toolchain: stable - profile: minimal + - run: rustup --version - - uses: briansmith/actions-cache@v2 + - uses: briansmith/actions-cache@v3 with: path: | ~/.cargo/bin/cargo-deny @@ -81,7 +69,7 @@ jobs: - run: cargo install cargo-deny --locked --vers "0.8.5" - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false @@ -91,24 +79,10 @@ jobs: rustdoc: runs-on: ubuntu-22.04 - strategy: - matrix: - rust_channel: - - stable - - beta - - nightly - - include: - - target: x86_64-unknown-linux-gnu - steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - override: true - target: ${{ matrix.target }} - toolchain: ${{ matrix.rust_channel }} + - run: rustup --version - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false @@ -119,12 +93,9 @@ jobs: runs-on: ubuntu-22.04 steps: - - uses: briansmith/actions-rs-toolchain@v1 - with: - toolchain: stable - profile: minimal + - run: rustup --version - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false @@ -192,19 +163,16 @@ jobs: - if: ${{ contains(matrix.host_os, 'ubuntu') }} run: sudo apt-get update -y - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false + - run: rustup toolchain add --profile=minimal ${{ matrix.rust_channel }} + - run: rustup target add --toolchain=${{ matrix.rust_channel }} ${{ matrix.target }} + - if: ${{ !contains(matrix.host_os, 'windows') }} run: mk/install-build-tools.sh --target=${{ matrix.target }} ${{ matrix.features }} - - uses: briansmith/actions-rs-toolchain@v1 - with: - override: true - target: ${{ matrix.target }} - toolchain: ${{ matrix.rust_channel }} - - if: ${{ matrix.target == 'aarch64-pc-windows-msvc' }} run: | echo "C:\Program Files (x86)\Microsoft Visual Studio\2022\Enterprise\VC\Tools\Llvm\x64\bin" >> $GITHUB_PATH @@ -212,21 +180,21 @@ jobs: - if: ${{ !contains(matrix.host_os, 'windows') }} run: | - mk/cargo.sh test -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} + mk/cargo.sh +${{ matrix.rust_channel }} test -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} - if: ${{ contains(matrix.host_os, 'windows') }} run: | - cargo test -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} + cargo +${{ matrix.rust_channel }} test -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} # rcgen-based tests require Rust 1.67. - if: ${{ !contains(matrix.host_os, 'windows') && !contains(matrix.rust_channel, '1.61.0') }} run: | - mk/cargo.sh test -p rcgen-tests -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} + mk/cargo.sh +${{ matrix.rust_channel }} test -p rcgen-tests -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} # rcgen-based tests require Rust 1.67, and uses *ring* 0.16 which doesn't build for aarch64-pc-windows-msvc. - if: ${{ contains(matrix.host_os, 'windows') && !contains(matrix.rust_channel, '1.61.0') && !contains(matrix.target, 'aarch64-pc-windows-msvc') }} run: | - cargo test -vv -p rcgen-tests --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} + cargo +${{ matrix.rust_channel }} test -vv -p rcgen-tests --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} coverage: runs-on: ${{ matrix.host_os }} @@ -256,24 +224,21 @@ jobs: - if: ${{ contains(matrix.host_os, 'ubuntu') }} run: sudo apt-get update -y - - uses: briansmith/actions-checkout@v2 + - uses: briansmith/actions-checkout@v4 with: persist-credentials: false + - run: rustup toolchain add --profile=minimal ${{ matrix.rust_channel }} + - run: rustup target add --toolchain=${{ matrix.rust_channel }} ${{ matrix.target }} + - if: ${{ !contains(matrix.host_os, 'windows') }} run: RING_COVERAGE=1 mk/install-build-tools.sh --target=${{ matrix.target }} ${{ matrix.features }} - - uses: briansmith/actions-rs-toolchain@v1 - with: - override: true - target: ${{ matrix.target }} - toolchain: ${{ matrix.rust_channel }} - - if: ${{ !contains(matrix.host_os, 'windows') }} run: | RING_COVERAGE=1 mk/cargo.sh +${{ matrix.rust_channel }} test --workspace -vv --target=${{ matrix.target }} ${{ matrix.cargo_options }} ${{ matrix.features }} ${{ matrix.mode }} - - uses: briansmith/codecov-codecov-action@v1 + - uses: briansmith/codecov-codecov-action@v3 with: directory: ./target/${{ matrix.target }}/debug/coverage/reports fail_ci_if_error: true From 826df27994156b8c8a0700fa972f1839298d0250 Mon Sep 17 00:00:00 2001 From: Brian Smith Date: Tue, 5 Dec 2023 16:15:47 -0800 Subject: [PATCH 3/3] CI: Remove unneeded workaround for no-longer-supported Rust version --- .github/workflows/ci.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 00aa4612..7d86e1e7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -136,11 +136,6 @@ jobs: - beta - exclude: - # 1.46.0 doesn't support `-Clink-self-contained`. - - target: x86_64-unknown-linux-musl - rust_channel: 1.46.0 - include: - target: aarch64-pc-windows-msvc host_os: windows-latest