You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
I noticed the release note says it is not backward compatible for Babylon.js v4, so I think the release should be undone and release as a major version instead of a patch version. Otherwise, if someone accidentally updates to this version, the app will crash.
The reason will be displayed to describe this comment to others. Learn more.
It’s not v5 compatible. It was an experiment that was meant to be v4 and v5 compatible, but with fluentMaterial and another interface moved it fails in 5 alpha. I had actually already tried 5alpha upgrade months ago with same issues. I will do a major bump and need to reconsider how I load classes in the reconciler and still do tree shaking.
The reason will be displayed to describe this comment to others. Learn more.
hi @Chargeuk I started looking at supporting 5.0 back in May (https://forum.babylonjs.com/t/babylonreactnative-in-new-react-native-project-thats-not-the-playground/20938/2). I just asked if an additional export would be considered, but probably it is a breaking change. This library design is partially based on the babylonjs philosophy trying to not introduce breaking changes. There are so many new things in 5.0 that I'm happy to move main branch to be 5.0 going forward.
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the release note says it is not backward compatible for Babylon.js v4, so I think the release should be undone and release as a major version instead of a patch version. Otherwise, if someone accidentally updates to this version, the app will crash.
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should follow Semantic Versioning
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brianzinn - nice, I created a v5 compatible release just yesterday 😂 - I’ll update it’s info to ensure people use this one instead 👍
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s not v5 compatible. It was an experiment that was meant to be v4 and v5 compatible, but with fluentMaterial and another interface moved it fails in 5 alpha. I had actually already tried 5alpha upgrade months ago with same issues. I will do a major bump and need to reconsider how I load classes in the reconciler and still do tree shaking.
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Chargeuk I started looking at supporting 5.0 back in May (https://forum.babylonjs.com/t/babylonreactnative-in-new-react-native-project-thats-not-the-playground/20938/2). I just asked if an additional export would be considered, but probably it is a breaking change. This library design is partially based on the babylonjs philosophy trying to not introduce breaking changes. There are so many new things in 5.0 that I'm happy to move main branch to be 5.0 going forward.
0e5097cThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, glad to hear it. 👍🏻