Skip to content
This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Commit 5cb7a33

Browse files
committedDec 27, 2016
comment grammar tweaks
spelling and spacing parameter singular space after # when not an issue number typo fix "explicity" fix a bad SparseMatrix find-replace in a comment fix 'situtations' typo
1 parent 915a07d commit 5cb7a33

14 files changed

+27
-27
lines changed
 

‎base/multidimensional.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ rcum_promote_type{T}(op, ::Type{T}) = T
493493
rcum_promote_type{T,N}(op, ::Type{Array{T,N}}) = Array{rcum_promote_type(op,T), N}
494494

495495
# accumulate_pairwise slightly slower then accumulate, but more numerically
496-
# stable in certain situtations (e.g. sums).
496+
# stable in certain situations (e.g. sums).
497497
# it does double the number of operations compared to accumulate,
498498
# though for cheap operations like + this does not have much impact (20%)
499499
function _accumulate_pairwise!{T, Op}(op::Op, c::AbstractVector{T}, v::AbstractVector, s, i1, n)::T

‎base/profile.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ The keyword arguments can be any combination of:
115115
sorts in order of number of collected samples.
116116
117117
- `noisefloor` only shows frames that exceed the heuristic noise floor of the sample (only applies to format `:tree`).
118-
A suggested value to try for this is 2.0 (the default is 0). This parameters hides samples for which `n <= noisefloor * √N`,
118+
A suggested value to try for this is 2.0 (the default is 0). This parameter hides samples for which `n <= noisefloor * √N`,
119119
where `n` is the number of samples on this line, and `N` is the number of samples for the callee.
120120
121121
- `mincount` can also be used to limit the printout to only those

‎doc/src/manual/modules.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -233,7 +233,7 @@ imports, the Julia build, files it includes, or explicit dependencies declared b
233233
in the module file(s).
234234

235235
For file dependencies, a change is determined by examining whether the modification time (mtime)
236-
of each file loaded by `include` or added explicity by `include_dependency` is unchanged, or equal
236+
of each file loaded by `include` or added explicitly by `include_dependency` is unchanged, or equal
237237
to the modification time truncated to the nearest second (to accommodate systems that can't copy
238238
mtime with sub-second accuracy). It also takes into account whether the path to the file chosen
239239
by the search logic in `require` matches the path that had created the precompile file.

‎src/ccall.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,10 @@ static Value *runtime_sym_lookup(PointerType *funcptype, const char *f_lib,
146146
Constant *initnul = ConstantPointerNull::get((PointerType*)T_pvoidfunc);
147147
LoadInst *llvmf_orig = builder.CreateAlignedLoad(llvmgv, sizeof(void*));
148148
// This in principle needs a consume ordering so that load from
149-
// this pointer sees valid value. However, this is not supported by
149+
// this pointer sees a valid value. However, this is not supported by
150150
// LLVM (or agreed on in the C/C++ standard FWIW) and should be
151151
// almost impossible to happen on every platform we support since this
152-
// ordering is enforced by the hardware and LLVM has to speculate a
152+
// ordering is enforced by the hardware and LLVM has to speculate an
153153
// invalid load from the `cglobal` but doesn't depend on the `cglobal`
154154
// value for this to happen.
155155
// llvmf_orig->setAtomic(AtomicOrdering::Consume);
@@ -324,7 +324,7 @@ static Value *emit_plt(FunctionType *functype, const AttributeSet &attrs,
324324
GlobalVariable *got = prepare_global(shadowgot);
325325
LoadInst *got_val = builder.CreateAlignedLoad(got, sizeof(void*));
326326
// See comment in `runtime_sym_lookup` above. This in principle needs a
327-
// consume ordering too. This is even less likely to cause issue though
327+
// consume ordering too. This is even less likely to cause issues though
328328
// since the only thing we do to this loaded pointer is to call it
329329
// immediately.
330330
// got_val->setAtomic(AtomicOrdering::Consume);

‎src/codegen.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -3862,7 +3862,7 @@ static Function *gen_cfun_wrapper(jl_function_t *ff, jl_value_t *jlrettype, jl_t
38623862

38633863
// figure out how to repack this type
38643864
if (!specsig) {
3865-
Value *arg = boxed(inputarg, &ctx, false); // don't want a gcroot, since it's about to be but into the jlcall frame anyways
3865+
Value *arg = boxed(inputarg, &ctx, false); // don't want a gcroot, since it's about to be put into the jlcall frame anyways
38663866
GetElementPtrInst *slot = GetElementPtrInst::Create(LLVM37_param(NULL) myargs,
38673867
ArrayRef<Value*>(ConstantInt::get(T_int32, FParamIndex)));
38683868
slot->insertAfter(ctx.ptlsStates);
@@ -6034,7 +6034,7 @@ static inline std::string getNativeTarget()
60346034
{
60356035
std::string cpu = sys::getHostCPUName();
60366036
#if defined(_CPU_ARM_)
6037-
// Try slightly harder than LLVM at determine the CPU architecture.
6037+
// Try slightly harder than LLVM at determining the CPU architecture.
60386038
if (cpu == "generic") {
60396039
// This is the most reliable way I can find
60406040
// `/proc/cpuinfo` changes between kernel versions

‎src/jitlayers.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -756,9 +756,9 @@ static void jl_merge_module(Module *dest, std::unique_ptr<Module> src)
756756
}
757757
}
758758

759-
// to finalizing a function, look up its name in the `module_for_fname` map of unfinalized functions
760-
// and merge it, plus any other modules it depends upon, into `collector`
761-
// then add `collector` to the execution engine
759+
// to finalize a function, look up its name in the `module_for_fname` map of
760+
// unfinalized functions and merge it, plus any other modules it depends upon,
761+
// into `collector` then add `collector` to the execution engine
762762
static StringMap<Module*> module_for_fname;
763763
static void jl_merge_recursive(Module *m, Module *collector);
764764

‎src/llvm-gcroot.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -248,8 +248,8 @@ void JuliaGCAllocator::lowerHandlers()
248248
typedef std::map<CallInst*,HandlerData>::iterator hdlr_iter_t;
249249
// For each exception enter, compute the life time of the enter, find
250250
// the corresponding leaves and collect a list of nested exception frames.
251-
// This assumes the exception frames has simple structure. E.g.
252-
// there's no recursion and different frames do no share the same leave.
251+
// This assumes the exception frames have simple structure. E.g.
252+
// there's no recursion and different frames do not share the same leave.
253253
std::function<void(hdlr_iter_t)> process_handler = [&] (hdlr_iter_t hdlr) {
254254
auto enter = hdlr->first;
255255
auto &data = hdlr->second;
@@ -338,7 +338,7 @@ void JuliaGCAllocator::lowerHandlers()
338338
Value *handler_sz = ConstantInt::get(T_int32, sizeof(jl_handler_t));
339339
// Now allocate the stack slots.
340340
// At each iteration, we allocate a new handler and assign all the remaining
341-
// frames that doesn't have a non-processed child to this handler.
341+
// frames that don't have a non-processed child to this handler.
342342
Instruction *firstInst = &F.getEntryBlock().front();
343343
while (!handlers.empty()) {
344344
processing.clear();

‎src/signals-unix.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ static inline __attribute__((unused)) uintptr_t jl_get_rsp_from_ctx(const void *
7676
static void jl_call_in_ctx(jl_ptls_t ptls, void (*fptr)(void), void *_ctx)
7777
{
7878
// Modifying the ucontext should work but there is concern that
79-
// sigreturn orientated programming mitigation can work against us
79+
// sigreturn oriented programming mitigation can work against us
8080
// by rejecting ucontext that is modified.
8181
// The current (staged) implementation in the Linux Kernel only
8282
// checks that the syscall is made in the signal handler and that

‎test/TestHelpers.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ function open_fake_pty()
3131
ccall(:ptsname, Ptr{UInt8}, (Cint,), fdm), O_RDWR|O_NOCTTY)
3232

3333
# slave
34-
slave = RawFD(fds)
34+
slave = RawFD(fds)
3535
master = Base.TTY(RawFD(fdm); readable = true)
3636
slave, master
3737
end

‎test/abstractarray.jl

+3-3
Original file line numberDiff line numberDiff line change
@@ -746,17 +746,17 @@ let
746746
@test !issparse(m2)
747747
end
748748

749-
#isinteger and isreal
749+
# isinteger and isreal
750750
@test isinteger(Diagonal(rand(1:5,5)))
751751
@test isreal(Diagonal(rand(5)))
752752

753-
#unary ops
753+
# unary ops
754754
let A = Diagonal(rand(1:5,5))
755755
@test +(A) == A
756756
@test *(A) == A
757757
end
758758

759-
#flipdim on empty
759+
# flipdim on empty
760760
@test flipdim(Diagonal([]),1) == Diagonal([])
761761

762762
# ndims and friends

‎test/arrayops.jl

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This file is a part of Julia. License is MIT: http://julialang.org/license
22

3-
#Array test
3+
# Array test
44

55
@testset "basics" begin
66
@test length([1, 2, 3]) == 3
@@ -431,7 +431,7 @@ end
431431
@test findmin([3.2,1.8,NaN,2.0]) == (1.8,2)
432432
@test findmax([3.2,1.8,NaN,2.0]) == (3.2,1)
433433

434-
# #14085
434+
#14085
435435
@test findmax(4:9) == (9,6)
436436
@test indmax(4:9) == 6
437437
@test findmin(4:9) == (4,1)
@@ -444,14 +444,14 @@ end
444444

445445
@testset "permutedims" begin
446446

447-
#keeps the num of dim
447+
# keeps the num of dim
448448
p = randperm(5)
449449
q = randperm(5)
450450
a = rand(p...)
451451
b = permutedims(a,q)
452452
@test isequal(size(b), tuple(p[q]...))
453453

454-
#hand made case
454+
# hand made case
455455
y = zeros(1,2,3)
456456
for i = 1:6
457457
y[i]=i
@@ -463,7 +463,7 @@ end
463463
z[i+3] = i*2
464464
end
465465

466-
#permutes correctly
466+
# permutes correctly
467467
@test isequal(z,permutedims(y,[3,1,2]))
468468
@test isequal(z,permutedims(y,(3,1,2)))
469469

‎test/file.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -862,7 +862,7 @@ if !is_windows()
862862

863863
# mv ----------------------------------------------------
864864
# move all 4 existing dirs
865-
# As expected this will leave some absolute links brokern #11145#issuecomment-99315168
865+
# As expected this will leave some absolute links broken #11145#issuecomment-99315168
866866
for d in [copytodir, maindir_new, maindir_new_keepsym, maindir]
867867
d_mv = joinpath(dirname(d), "$(basename(d))_mv")
868868
mv(d, d_mv; remove_destination=true)

‎test/libgit2.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -751,7 +751,7 @@ mktempdir() do dir
751751
finalize(repo)
752752
end
753753
"""
754-
# We try to be helpful by desparately looking for
754+
# We try to be helpful by desperately looking for
755755
# a way to prompt the password interactively. Pretend
756756
# to be a TTY to suppress those shenanigans. Further, we
757757
# need to detach and change the controlling terminal with

‎test/sparse/sparsevector.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,7 @@ let testdims = (10, 20, 30), nzprob = 0.4, targetnumposzeros = 5, targetnumnegze
10411041
@test exact_equal(xdrop, SparseVector(7, [1, 3, 5, 7], [3, -1., -2., 3.]))
10421042
end
10431043

1044-
# It's tempting to share data between a SparseVector and a SparseArrays,
1044+
# It's tempting to share data between a SparseVector and a SparseMatrix,
10451045
# but if that's done, then modifications to one or the other will cause
10461046
# an inconsistent state:
10471047
sv = sparse(1:10)

0 commit comments

Comments
 (0)
This repository has been archived.