alt prop warning in build

[krancour]

Let's fix this:

WARNING in src/App.tsx
  Line 61:19:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/alt-text

This is the logo-- I think we can count that as "decorative" and use an empty string.

[DhairyaBahl]

@krancour I would love to work on this as well ! Kindly assign this to me.

[krancour]

@DhairyaBahl looks like someone beat you to it. See linked PR #11.

[DhairyaBahl]

@DhairyaBahl looks like someone beat you to it. See linked PR #11.

haha ! That's totally not an issue. I haven't seen that there was already a Pull Request for this issue. I will check out other issues.

[AnuragThePathak]

Is anyone working on it?

[krancour]

@coder-abdo opened two different PRs related to this and closed them both.

@AnuragThePathak if you want to work on this, go ahead.

[AnuragThePathak]

Sure would like to work.

[AnuragThePathak]

The error says line 61 i.e.

brigade-dashboard/src/App.tsx

Line 61 in ade15c5

<LinkContainer to="/projects">

.

This is the logo-- I think we can count that as "decorative" and use an empty string.

How the problem is in logo

[krancour]

The contents of that file must have changed between when the issue was written and now.

[krancour]

Please go by what the warnings currently say and not what's here.

[AnuragThePathak]

Actually when I run yarn run build I don't the above mentioned warning. Rather I get errors like the following one

Failed to parse source map from '/home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/src/api_client.ts' file: Error: ENOENT: no such file or directory, open '/home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/src/api_client.ts'

The correct path should be /home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/dist/api_client.ts. Not sure if it's fault in my system or misconfiguration in @brigadecore/brigade-sdk package. I haven't faced such warnings before, while working with any type of javascript/typescript project.

[krancour]

yarn start to see the warnings referenced in the original post.

[AnuragThePathak]

Actually when I run yarn run build I don't the above mentioned warning. Rather I get errors like the following one

Failed to parse source map from '/home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/src/api_client.ts' file: Error: ENOENT: no such file or directory, open '/home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/src/api_client.ts'

The correct path should be /home/anurag/Open-Source/brigade-dashboard/node_modules/@brigadecore/brigade-sdk/dist/api_client.ts. Not sure if it's fault in my system or misconfiguration in @brigadecore/brigade-sdk package. I haven't faced such warnings before, while working with any type of javascript/typescript project.

yarn start also shows 32 problems similar to this one. Please note that all such problems are in the @brigadecore/brigade-sdk package only.

[krancour]

Actually when I run yarn run build I don't the above mentioned warning. Rather I get errors like the following one

That is a separate and known issue. brigadecore/brigade-sdk-for-js#71

If you want to work on that, work on that issue, but this issue is about something else. Let's try to stay focused, please.

[AnuragThePathak]

Actually I'm not able to replicate the error mentioned in this issue that is

WARNING in src/App.tsx
  Line 61:19:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/alt-text

[krancour]

I'm not getting it now either and I don't know why that is. Let's put this issue on hold and work on something else.

[AnuragThePathak]

ok cool