Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improper Error Handling #41

Open
DhairyaBahl opened this issue Mar 9, 2022 · 2 comments
Open

Improper Error Handling #41

DhairyaBahl opened this issue Mar 9, 2022 · 2 comments

Comments

@DhairyaBahl
Copy link
Contributor

Description

Taking an example of this async function, try{} catch{} is must with async/await. Otherwise, it will lead to unexpected behaviour.
image

Over Here, this.props functions should only be called on successful Login/Logout but right now it just changes the state.
image
@krancour
Copy link
Contributor

krancour commented Mar 9, 2022

Over Here, this.props functions should only be called on successful Login/Logout but right now it just changes the state.

That aspect of this is fixed in #44.

@krancour
Copy link
Contributor

krancour commented Mar 9, 2022

Also note that error-handling, in general, wasn't addressed yet because reading up on error boundaries was still on my TODO list.

Happy for help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krancour @DhairyaBahl